[ 
https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830696#action_12830696
 ] 

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

hi Jacques,
i had a look to your patch.
The Accounting Module works fine with the new lookups. 
But by replacing the decorator screens in the common modul, some other (old) 
lookups looks quite ugly now :-) (They uses the new decorator which didn't load 
the nessary css files for the (old) lookups). You can see this i.e. in the 
catalog manager. [https://localhost:8443/catalog/control/main]. 

It's not a big deal, i think, because it's only for the interim period.

Have a nice day (WE)

Sascha  

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered 
> lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, 
> OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and 
> improvements OFBIZ-3430, I propose now to replace old the popup lookups by 
> layered (Ajaxified) lookups. 
> For that please find a patch attached. In this patch I followed a simple S/R 
> tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator 
> in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" 
> position="center"
> It's as simple as this. For the moment I decided to use as default 
> position="center" because it's was the easiest (sure that any lookups will be 
> out of the screen). I think we will refine this by removing position="center" 
> and use the default (position="normal") which does not move the layer from 
> the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use 
> layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a 
> lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as 
> possible. I really think it's a very cool feature for users, and they will 
> appreciate. There are still some ideas like that (see the link Sasca referred 
> to in OFBIZ-3374), and we will try to implement them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to