[ 
https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830737#action_12830737
 ] 

Bilgin Ibryam commented on OFBIZ-3442:
--------------------------------------

Hi Jacques and Sascha, this a great addition, thanks a lot for working on it. 

I did some quick tests. Here is what I found.

Before few weeks I added autocompleter support to lookup fields. (If you didn't 
see it, just type one/two letters in a lookup field and you can select an entry 
w/o using the lookup button). It was missing in LookupLayerPopupDecorator and I 
added it in r907456. Now autocompleter and layered lookups work together fine :)

I didn't follow all the development process of the layered lookups, but why not 
change the default values in the schema of presentation and position elements 
to layer and center respectively. Then we don't need to add these attributes in 
all the forms.

Also I found a bug caused when user session is destroyed: Log into an 
application (accounting for example) and select a form - layered lookups work 
correct. In another tab log into another application and then log out.  Then on 
the first tab (accounting) try to use a lookup. In the lookup screen you will 
get the login screen (that's OK) but once you enter your username and password 
you get a blank screen.


Bilgin


> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered 
> lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, 
> OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace 
> popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and 
> improvements OFBIZ-3430, I propose now to replace old the popup lookups by 
> layered (Ajaxified) lookups. 
> For that please find a patch attached. In this patch I followed a simple S/R 
> tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator 
> in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" 
> position="center"
> It's as simple as this. For the moment I decided to use as default 
> position="center" because it's was the easiest (sure that any lookups will be 
> out of the screen). I think we will refine this by removing position="center" 
> and use the default (position="normal") which does not move the layer from 
> the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use 
> layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a 
> lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as 
> possible. I really think it's a very cool feature for users, and they will 
> appreciate. There are still some ideas like that (see the link Sasca referred 
> to in OFBIZ-3374), and we will try to implement them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to