David E Jones wrote: > On Feb 26, 2010, at 11:01 AM, Adam Heath wrote: > >> Adam Heath wrote: >>> David E Jones wrote: >>>> On Feb 26, 2010, at 10:33 AM, Adam Heath wrote: >>>> >>>>> Adam Heath (JIRA) wrote: >>>>>> [ >>>>>> https://issues.apache.org/jira/browse/OFBIZ-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>>>>> ] >>>>>> >>>>>> Adam Heath updated OFBIZ-3520: >>>>>> ------------------------------ >>>>>> >>>>>> Attachment: 897606-testcase.patch >>>>>> >>>>>>> revision 897605 breaks certain delegator.find() EntityListIterator calls >>>>>>> ------------------------------------------------------------------------ >>>>>>> >>>>>>> Key: OFBIZ-3520 >>>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-3520 >>>>>>> Project: OFBiz >>>>>>> Issue Type: Bug >>>>>>> Components: framework >>>>>>> Affects Versions: SVN trunk >>>>>>> Reporter: Adam Heath >>>>>>> Assignee: David E. Jones >>>>>>> Attachments: 897606-testcase.patch >>>>>>> >>>>>>> >>>>>>> We recently upgraded our internal ofbiz package to a newer trunk >>>>>>> version, one from the end of January. Ean then deployed that to the >>>>>>> server it was developing on. This broke requirements processing. I >>>>>>> have reduced it, however, to a simple patch, that works if I revert >>>>>>> 897606, but breaks when it is applied. >>>>>>> Test case will be attached. >>>>> David, could you please take a look at this, as it is your commit that >>>>> causes this to break. >>>> Did you read the discussion about this? >> Which discussion? I don't see any discussion mentioned in the >> changelog, I went back to Jan 10, don't see anything near by. >> >>>> Just search for the revision number. >> I searched my own mail archive, which goes back to 12-31, and there >> are no hits on 897606, except for your original commit mail, and this >> issue/thread. >> >>>> I believe it has already been fixed, and you'll either have to update to >>>> something more recent or back-port the fix. >> The issue in the requirements system is not the problem. I have given >> a test case that stands by itself, that is broken with your commit >> applied, and works without it. The test case is doing something >> completely reasonable, and was supported by previous versions of ofbiz. >> >> I have checked that I didn't miss anything, and I haven't. > > Of course you haven't! It sounds like you have a complete understanding of > the problem.
If I had a complete understanding of the problem, I would have fixed it. But I saw no discussion about this change, so I can't infer what others haven't said. You said previously that there was a discussion about this earlier. I then said that I couldn't find it. So, what was the discussion? Give me something to search for. > Oh, BTW the rev number is 897605, not 897606. Yeah, my bad/ > > Please see my other comments and questions on the Jira issue, if you care to > of course. > > On a side note, about being combative, why spend so much time isolating a > revision instead of understanding the technical problem? I guess I ask > because I pretty much never bother to track down who caused the problem and > when... what good does that do except allow me to play the blame game. It > certainly doesn't help me fix the problem. I suppose that's just my style, > and I guess that conflicts with your style. I just hope I'm always around to > help you with every thing I might have worked on in OFBiz. Isolating a single revision that causes a problem doesn't pin the blame. It shows what needs to be fixed. Would it have been better if I just filed a test case that didn't work, and made others investigate? I've saved others time by finding the single revision that causes the case to break. This is not a blame game, no. I never blamed you for causing this breakage. You just did the original commit, so I assumed you'd know more about the situation that your change would be useful. Your commit was trying to fix something else, so it's needed in some case.
