On Mar 19, 2010, at 12:04 PM, Adam Heath wrote: > Jacopo Cappellato wrote: >> On Mar 19, 2010, at 6:43 PM, Adam Heath wrote: >> >>> [email protected] wrote: >>>> Author: jacopoc >>>> Date: Fri Mar 19 17:23:15 2010 >>>> New Revision: 925342 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=925342&view=rev >>>> Log: >>>> Improved search capabilities of the work effort calendar screens; >>>> converted ftl template to form widget. >>> This should have been 2 commits, they aren't related. >>> >> >> I enhanced the search features by replacing the existing ftl forms (one for >> each search field) with *one* single widget form: in this way searches can >> be done with multiple constraints. >> Are you saying that instead I should have: >> >> 1) converted the ftl forms into widget forms in order to preserve the >> original limitations >> 2) aggregate the widget forms into one widget form in order to implement the >> new feature >> >> ? >> >> This is the most ridiculous thing I have ever heard. Or maybe it is a new >> *policy*? > > The reason it's good to split it, is that the conversion from ftl to > widget might introduce bugs, just the conversion itself. Trying to > track the problem down in the future when the bug is actually found is > much simpler to do when the change is isolated. > > All you can say about any bit of code, is that you've fixed all > *known* bugs. There could be an unknown bug in the conversion, that > is only discovered in the future. The split makes it simpler to track > down.
Adam: Maybe you need to consider a different approach to debugging, as I've mentioned before, like understanding the code. This stuff is all deterministic, there is no reason to resort to experimentation. -David
