Hi Blas, the work you have done seems great! I will be glad to help reviewing and committing your work.
You could create a patch for each component (content, accounting, etc,) (a patch will address more files) and attach them to one or more JIRAs. -Bruno 2010/3/29 Blas Rodriguez Somoza <blas.rodrig...@fractalia.com> > Hello > > I'm currently evaluating OFbiz for a project. > > Some days ago, I begun playing with the demo and I try to validate the > pages against xhtml. > > I use the tomahawk theme and the database loaded with the demo seed data. > > I test the 261 pages which are accesible directly from the main menu of > each one of the 27 applications included in the demo menu (and also those > pages which are accesible from the top tab-bar of each of the included > pages). > > Initially near all the pages of don't pass the validation, but I discover > that there are a lot of minor issues, so and can't resist the temptation and > I start to patch it. > > Most corrections are only due to old html not being xhtml conformant > - Unclosed INPUT > - attributes without values (checked, selected, disabled, etc) > - attribute values without " > - Uppercase tags or attributes. > - Unencoded ampersands in urls. > > But as I get rid of those I've found some real errors, and correct most > of them. > > Five days after I start, I have a lot of patched files, and 80% of the > pages pass the validation (221 of 261) ignoring the error about autocomplete > attribute not valid in input tags. > > About the 50 pages which don't pass the validation, 40 of them are due to > issues related with editable tables. > > First question: Is there any commiter who want and have the time to > review/commit those patches ? > If the answer is to 1st question is yes, then: > > I suppose the best method to send the patches is through diff files to > JIRA, but there are 252 ftl, 5 xml and 5 java files affected, so the patches > should be grouped to be usable. > > Second question: which will be the preferred grouping for the patches? > > Regards > Blas >
