[
https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blas Rodriguez Somoza updated OFBIZ-3621:
-----------------------------------------
Description:
XHTML validation errors
* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.
Other errors:
Header.ftl (tomahawk & droppingcrumbs)
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
title="${layoutSettings.companyName}"><div> </div></a>
Style.css (tomahawk & droppingcrumbs)
Line 945. The logo is used as the background of the logo area, but because the
size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;
Solution: This is a hack to put the logo in the style sheet as the background.
If the logo is only in the stylesheet without any trick, the logo will be
clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear
without clip and without any hack in header.ftl.
appbarOpen.ftl (droppingcrumbs)
Line 99, unclosed <li> and <ul>
header.ftl (bizznesstime)
Line 111. div can't be inside span.
Updated patch attached (v2)
was:
XHTML validation errors
* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.
Other errors:
Header.ftl
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
title="${layoutSettings.companyName}"><div> </div></a>
Style.css
Line 945. The logo is used as the background of the logo area, but because the
size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;
Solution: This is a hack to put the logo in the style sheet as the background.
If the logo is only in the stylesheet without any trick, the logo will be
clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear
without clip and without any hack in header.ftl.
Patch attached.
> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
> title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because
> the size of the background image means nothing for dimensioning, it will be
> clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the
> background. If the logo is only in the stylesheet without any trick, the logo
> will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear
> without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
