[
https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851671#action_12851671
]
Blas Rodriguez Somoza edited comment on OFBIZ-3621 at 3/31/10 12:31 AM:
------------------------------------------------------------------------
Hello Bruno
It's true, although I don't note it previously.
The dark line appear because the height of the li element is greater than the
height of the image due to an error in the browser implementation, only Opera
seems to do the right thing.
See the li_img_error.jpg (the yellow rectangle is the image outer box and the
red rectangle is the ul outter box)
To solve the problem, the ul height must be fixed in the "masthead li ul" css
entry. Before my patches, this height is fixed in the logo-area css entry which
now is obsolete.
I make the correction for tomahawk and droppingcrumbs
I added a corrected patch (v3)
was (Author: brsomoza):
Hello Bruno
It's true, although I don't note it previously.
The problem because the height of the li element are greater than the height of
the image due to an error in the browser implementation, only Opera seems to do
the right thing.
See the li_img_error.jpg (the yellow rectangle is the image outer box and the
red rectangle is the ul outter box)
To solve the problem, the ul height must be fixed in the "masthead li ul" css
entry. Before my patches, this height is fixed in the logo-area css entry which
now is obsolete.
I make the correction for tomahawk and droppingcrumbs
I added a corrected patch (v3)
> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg,
> OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff,
> OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
> title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because
> the size of the background image means nothing for dimensioning, it will be
> clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the
> background. If the logo is only in the stylesheet without any trick, the logo
> will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear
> without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
