[
https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852621#action_12852621
]
Blas Rodriguez Somoza commented on OFBIZ-3621:
----------------------------------------------
Hi Bruno.
Thanks for your time.
Finally your comments shows me that changing the logo url from css to markup
could be disrupting and I look again for a simpler solution, which I didn't
find initially.
And I find it, the new patch (v5) only replaces div with span and changes the
css sizing from the div to the li element which contain the logo, this is
enough to render the page header exactly as it is now and avoid the xhtml
validation error.
Regards.
Blas
Note: Although I'll not use it, I've found the way to avoid the LI height error
in FF and IE (using line-height:0 and font-size:0)
> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg,
> OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff,
> OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ-3621_themes_xhtml_v5.diff,
> OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
> title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because
> the size of the background image means nothing for dimensioning, it will be
> clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the
> background. If the logo is only in the stylesheet without any trick, the logo
> will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear
> without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
