[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236135#comment-13236135 ]
Jacques Le Roux edited comment on OFBIZ-4723 at 3/22/12 10:46 PM: ------------------------------------------------------------------ Edit ========= forgot \{code\} rhaaa²============ Anne, You don't need to do that when there is only one line, Debug.logInfo() will do it by itself. There is only a real gain when there are more than one line. {code} - Debug.logInfo("Current file : " + fileInfo.getFileName(), module); + if (Debug.infoOn()) { + Debug.logInfo("Current file : " + fileInfo.getFileName(), module); + } {code} was (Author: jacques.le.roux): Edit ========= forgot {code} ============ Anne, You don't need to do that when there is only one line, Debug.logInfo() will do it by itself. There is only a real gain when there are more than one line. {code} - Debug.logInfo("Current file : " + fileInfo.getFileName(), module); + if (Debug.infoOn()) { + Debug.logInfo("Current file : " + fileInfo.getFileName(), module); + } {code} > Support validation of resource xml files > ---------------------------------------- > > Key: OFBIZ-4723 > URL: https://issues.apache.org/jira/browse/OFBIZ-4723 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: REV 1297286 > Reporter: Anne Jessel > Priority: Minor > Attachments: OFBIZ-4723_code_cleanups.patch, > OFBIZ-4723_support-validation-resource-xml.patch > > > The xsd for the resource xml files is invalid. In addition, the format of the > value of the xml:lang attribute in resource xml files is invalid, according > to the xml standard. > The attached patch: > * provides a valid xsd > * updates UtilProperties and the Label Manager to deal with the correct > formatting of the xml:lang value, while still working with the old format, > following Adrian Crum's recommendation on the mailing list > * includes simple unit tests for UtilProperties to ensure it does work with > both formats > * changes the Label Manager to include a reference to the new xsd, and to use > the correct format of the xml:lang value, when writing a resource xml file. > This problem exists in released versions, but I doubt it is important enough > to back port. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira