[
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236163#comment-13236163
]
Anne Jessel commented on OFBIZ-4723:
------------------------------------
Jacques
The purpose of the Debug.infoOn() call is to avoid unnecessary string
concatenations and unnecessary object creation, which are slow operations. It
also reduces the need for garbage collection. There is lots of advice around
the web to follow this pattern, unless the log message does not include any
concatenation or conversions. For example:
http://logging.apache.org/log4j/1.2/faq.html#a2.3 and
http://blog.progs.be/91/isdebugenabled
> Support validation of resource xml files
> ----------------------------------------
>
> Key: OFBIZ-4723
> URL: https://issues.apache.org/jira/browse/OFBIZ-4723
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: REV 1297286
> Reporter: Anne Jessel
> Priority: Minor
> Attachments: OFBIZ-4723_code_cleanups.patch,
> OFBIZ-4723_support-validation-resource-xml.patch
>
>
> The xsd for the resource xml files is invalid. In addition, the format of the
> value of the xml:lang attribute in resource xml files is invalid, according
> to the xml standard.
> The attached patch:
> * provides a valid xsd
> * updates UtilProperties and the Label Manager to deal with the correct
> formatting of the xml:lang value, while still working with the old format,
> following Adrian Crum's recommendation on the mailing list
> * includes simple unit tests for UtilProperties to ensure it does work with
> both formats
> * changes the Label Manager to include a reference to the new xsd, and to use
> the correct format of the xml:lang value, when writing a resource xml file.
> This problem exists in released versions, but I doubt it is important enough
> to back port.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
