[ 
https://issues.apache.org/jira/browse/OFBIZ-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254348#comment-13254348
 ] 

Jacques Le Roux commented on OFBIZ-4797:
----------------------------------------

Sorry Tom,

Your patch does not apply:

D:\workspace\ofbizClean>patch -N -p0  0<"OFBIZ-4797 eCommerce Draft.patch"
patching file specialpurpose/ecommerce/widget/CustomerScreens.xml
patching file specialpurpose/ecommerce/widget/CommonScreens.xml
patching file 
specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditContactMech.groovy
patching file 
specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
Hunk #4 FAILED at 173.
1 out of 4 hunks FAILED -- saving rejects to file 
specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl.rej

rejected:
{code}
--- specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
+++ specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
@@ -176,15 +173,23 @@
           <input type="text" class='inputBox' size="12" maxlength="10" 
name="postalCode" value="${postalAddressData.postalCode?if_exists}" />
         *</td>
       </tr>
-      <tr>
-        <td align="right" valign="top">${uiLabelMap.PartyCountry}</td>
-        <td>&nbsp;</td>
-        <td>
-          <select name="countryGeoId" class='selectBox'>
-            <#if postalAddressData.countryGeoId?exists><option 
value='${postalAddressData.countryGeoId}'>${selectedCountryName?default(postalAddressData.countryGeoId)}</option></#if>
-            
${screens.render("component://common/widget/CommonScreens.xml#countries")}
+      <tr>   
+        <td align="right" valign="top">${uiLabelMap.CommonCountry} Postal 
address geoId ${postalAddress.countryGeoId}</td>
+        <td>&nbsp;</td>      
+        <td>     
+          <select name="countryGeoId" id="editcontactmechform_countryGeoId">
+          
${screens.render("component://common/widget/CommonScreens.xml#countries")}      
  
+          <#if (postalAddress?exists) && (postalAddress.countryGeoId?exists)>
+            <#assign defaultCountryGeoId = postalAddress.countryGeoId>
+          <#else>
+            <#assign defaultCountryGeoId = 
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue("general.properties",
 "country.geo.id.default")>
+          </#if>
+          <option selected="selected" value="${defaultCountryGeoId}">
+          <#assign countryGeo = 
delegator.findByPrimaryKey("Geo",Static["org.ofbiz.base.util.UtilMisc"].toMap("geoId",defaultCountryGeoId))>
+            ${countryGeo.get("geoName",locale)}
+          </option>
           </select>
-        *</td>
+        </td>
       </tr>
     <#elseif contactMechTypeId = "TELECOM_NUMBER">
       <tr>
{code}
                
> eCommerce Edit Contact Information use Dependent drop-downs
> -----------------------------------------------------------
>
>                 Key: OFBIZ-4797
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4797
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: demo-trunk
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-4797 eCommerce Draft.patch
>
>
> Using Dependent drop-downs to filter the State drop down based on the 
> selection in the Country drop-down will improve the usability of the 
> component.
> Current Behavior:
> 1. Open eCommerce application
> 2. Log in as user with Postal Address say Demo Customer
> 3. In the menu bar select Profile
> 4. In "Contact Information" > "Postal Address" select update.
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list displays all geo values.
> After improvement:
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list is limited to States in the United States.
> 6. Changing the value in the "Country" drop-down will update "State/Province" 
> drop-down list with values for the selected country.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to