[ 
https://issues.apache.org/jira/browse/OFBIZ-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254377#comment-13254377
 ] 

Tom Burns commented on OFBIZ-4797:
----------------------------------

Jacques,

You will probably have to fix this conflict manually. In editcontactmech.ftl 
table record below... 
      <tr>   
        <td align="right" valign="top">${uiLabelMap.CommonCountry} Postal 
address geoId ${postalAddress.countryGeoId}</td>
        <td>&nbsp;</td>      
        <td>     
          <select name="countryGeoId" id="editcontactmechform_countryGeoId">
          
${screens.render("component://common/widget/CommonScreens.xml#countries")}      
  
          <#if (postalAddress?exists) && (postalAddress.countryGeoId?exists)>
            <#assign defaultCountryGeoId = postalAddress.countryGeoId>
          <#else>
            <#assign defaultCountryGeoId = 
Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue("general.properties",
 "country.geo.id.default")>
          </#if>
          <option selected="selected" value="${defaultCountryGeoId}">
          <#assign countryGeo = 
delegator.findByPrimaryKey("Geo",Static["org.ofbiz.base.util.UtilMisc"].toMap("geoId",defaultCountryGeoId))>
            ${countryGeo.get("geoName",locale)}
          </option>
          </select>
        *</td>
      </tr>

... replaces the table record above
Above <#elseif contactMechTypeId = "TELECOM_NUMBER">

It is the same table record used by your fix for countryGeoId

By the way while working on the above I noticed a few additional issues in the 
eCommerce profile and the dependent drop down fix.

Dependent Drop Down
The Dependent drop down State/Province defaults to the first record after a 
refresh from the "Country Postal address".
The State/Province should be blank after a refresh and throw an alert if none 
is selected.
For example if the Country changes from US to United Kingdom then Aberdeenshire 
is selected.
The selection should be the responsibility of the user.

eCommerce profile
1. The "Go Back" button in the "Contact Information" Create and update screens 
(Postal Address, Phone Number etc.)
does not return to the Profile screen (viewprofile). 
Return to the Profile screen is the behavior for all similar buttons in the 
feature.

2. The buttons in "Payment Method Information" labeled Cancel/Done and are of 
two styles class="buttontext" and class="button".
"Cancel/Done" text may be confusing. After making a change in one for these 
forms the user may think that Cancel would undo the change. "Go Back" would be 
better. 

3. The buttons in the Profile screen itself use different styles.

I'll create issues for these unless you are of a different mind.

Tom 

                
> eCommerce Edit Contact Information use Dependent drop-downs
> -----------------------------------------------------------
>
>                 Key: OFBIZ-4797
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4797
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: demo-trunk
>            Reporter: Tom Burns
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-4797 eCommerce Draft.patch
>
>
> Using Dependent drop-downs to filter the State drop down based on the 
> selection in the Country drop-down will improve the usability of the 
> component.
> Current Behavior:
> 1. Open eCommerce application
> 2. Log in as user with Postal Address say Demo Customer
> 3. In the menu bar select Profile
> 4. In "Contact Information" > "Postal Address" select update.
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list displays all geo values.
> After improvement:
> 5. The "Country" drop-down value is "United States" and the "State/Province" 
> drop-down list is limited to States in the United States.
> 6. Changing the value in the "Country" drop-down will update "State/Province" 
> drop-down list with values for the selected country.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to