[
https://issues.apache.org/jira/browse/OFBIZ-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256611#comment-13256611
]
Tom Burns commented on OFBIZ-4822:
----------------------------------
Jacques,
I did not intentionally remove it.
Likely it was a sloppy cut an paste of the "Go Back" line from one of the other
files.
That said the authview is used inconsistently in eCommerce and only in the ftl
files in the Customer folder.
It calls the authview request in the controller which sets https before calling
main view.
The donePage call is set to viewprofile, which sets https, from all of the edit
forms off viewprofile.
So authview does not appear to be adding any value. The code would be clearer
without it.
I could be missing something in the logic.
It is not completely clear to me where donePage is picking up is value.
I see it set in Customer Screens > editperson, ChangePassword.groovy and some
of the form tags but nothing consistent.
Some things that were intentional:
1. For consistency I changed the behavior of editperson form. It returned to
viewprofile on save click while all other edit forms required clicking on the
done button.
2. Placed a paragraph after the buttons on the top line to separate them from
the horizontal table lines. The connection to the top horizontal line made the
form look like a tab form which is misleading.
3. For consistency modified the newcustomer form buttons, though it is outside
of the Profile feature, since they serve the same function.
Tom
> eCommerce Profile Improve Button Naming Consistency
> ---------------------------------------------------
>
> Key: OFBIZ-4822
> URL: https://issues.apache.org/jira/browse/OFBIZ-4822
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4822 eCommerce Profile GoBack Improvement.patch
>
>
> This follows from OFBIZ-4814 bug fix.
> In eCommerce the naming and display of back buttons is inconsistent across
> the Profile Editing screens.
> Example:
> Changes Password label should be "Go Back" but is "[Go Back]"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
