[
https://issues.apache.org/jira/browse/OFBIZ-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256676#comment-13256676
]
Jacques Le Roux commented on OFBIZ-4822:
----------------------------------------
Tom,
authview quickly fixed for now at r1327562
Interesting:
{quote}
That said the authview is used inconsistently in eCommerce and only in the ftl
files in the Customer folder.
It calls the authview request in the controller which sets https before calling
main view.
The donePage call is set to viewprofile, which sets https, from all of the edit
forms off viewprofile.
So authview does not appear to be adding any value. The code would be clearer
without it.
{quote}
I tend to agree from what yo are saying (no review I mean). Would you mind to
provide a patch to remove it, did you test it?
{quote}
It is not completely clear to me where donePage is picking up is value.
{quote}
I had a look before committing, since this is in the profile screen, and at the
top of it there is a call to the editperson screen, then it's intially set
there with default-value="viewprofile"
I agree with your 3 points, good catches. I saw also that you put the buttons
at top and bottom where they were missing (maybe it was you say in point 3.
BTW...)
> eCommerce Profile Improve Button Naming Consistency
> ---------------------------------------------------
>
> Key: OFBIZ-4822
> URL: https://issues.apache.org/jira/browse/OFBIZ-4822
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4822 eCommerce Profile GoBack Improvement.patch
>
>
> This follows from OFBIZ-4814 bug fix.
> In eCommerce the naming and display of back buttons is inconsistent across
> the Profile Editing screens.
> Example:
> Changes Password label should be "Go Back" but is "[Go Back]"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
