On Apr 18, 2012, at 7:37 PM, Adam Heath wrote: > On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: >> On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: >> >>> ps: I am going to switch <if> in ant *back* to javascript, *away* from >>> ant-contrib. The latter is significantly slower when using a system >>> installed ant. >> >> No please, don't do that. > > I've pointed out a problem, and I have a solution. Don't just respond > saying don't do that, without a reason. That isn't enough to stop me.
I thought that all the recent threads about code refactoring, moving out custom code etc... were enough to motivate my response; but it seems that you ignored all of them and now pretend a response from me, for such a trivial and small topic. The reason is that we want to keep code as clean as possible, as slim as possible (ok, I know it looks silly if you look at the code now... but we are determined to work on this): using an external tool for this instead of custom code is a step in this direction. The stats below show that the problem is trivial: it is only relevant when you use your own ant that is not what we recommend; and it is something that should be fixed with the ant community: in fact we want to increase the cooperation with other communities (especially if they are in the ASF world) rather than blobbing everything into OFBiz. Jacopo > > ant-contrib If-ant.js > (system-ant) > Apache Ant version 1.8.0 compiled on March 11 2010 > time ant clean 18.131s 8.291s > time ant build 44.072s 34.749s > time ant build 20.228s 10.559s > time ant clean 18.222s 8.490s > (local-ant) > Apache Ant(TM) version 1.8.3 compiled on February 26 2012 > time ./ant clean 3.575s 3.218s > time ./ant build 28.985s 28.909s > time ./ant build 5.486s 5.232s > time ./ant clean 3.876s 3.378s > > The first ant clean is run when the system is already cleaned. The > second ant build is also run when everything is already built. It's a > way to test what happens when nothing is done.
