This is a pretty strong statement about another Apache project....
Regards, Hans On 05/07/2012 02:06 PM, Jacopo Cappellato (JIRA) wrote:
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269416#comment-13269416 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ What I don't like about committing this fix is that it will fix the error and hide the bad design that was causing it. I had a quick look at the revision that Jacques mentioned (thank you) and I have noticed some very bad code: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java?view=markup&pathrev=736896 this class is not thread safe and if fact I already encountered a bad bug in production because of this; there are also some formatting issues... I understand that this class has been copied from another project (did we mention this in our notice file? I don't remember if it is mandatory but we should check) but rev. 736896 is a perfect example of code that should have never been committed in this way because it is dangerous, it doesn't meet minimal quality requirements.webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup ----------------------------------------------------------------------------------------------------- Key: OFBIZ-4856 URL: https://issues.apache.org/jira/browse/OFBIZ-4856 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Fix For: SVN trunk Attachments: OFBIZ-4856.patch During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.-- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
