Jacopo,
In general when we need an important function in OFBiz which is missing
like Captcha, we look in an existing Apache project first. If we find
it, we use it without much checking. I personally do not have enough
knowledge to provide you with a comment on thread "unsafety."
Regards,
Hans
On 05/07/2012 02:55 PM, Jacopo Cappellato (JIRA) wrote:
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269439#comment-13269439
]
Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------
Yep, that code is really awful; I had a look at the source files referenced in
Captcha.java:
http://cocoon.apache.org/2.2/blocks/captcha/1.0/1436_1_1.html
but I couldn't find that class... is the reference the right one?
By the way, there are two possibilities:
* the Cocoon code you have copied is really bad written
* the Cocoon code was not intended to be used in a multi threaded environment
like OFBiz is doing
In both ways the code as is should have never been committed.
Hans, apart from commenting my statements, do you have anything to say to the
thread unsafety of this class?
webapp "tempfiles" is not successfully loaded because of
java.io.FileNotFoundException during startup
-----------------------------------------------------------------------------------------------------
Key: OFBIZ-4856
URL: https://issues.apache.org/jira/browse/OFBIZ-4856
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Fix For: SVN trunk
Attachments: OFBIZ-4856.patch
During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to
load webapp "tempfiles" which is defined by framework/images component.
The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not
exist from the very first, catalina container will use default web.xml instead.
I apply a patch for this issue to catch the "java.io.FileNotFoundException" and
bypass it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
