[ 
https://issues.apache.org/jira/browse/OFBIZ-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290842#comment-13290842
 ] 

Jacques Le Roux commented on OFBIZ-4926:
----------------------------------------

Hi Chatree,

After reading the patch and your explanation, I have still a concern. The 
lookup mechanism needs a form name in order to render the description besides 
the lookup. You removed the check which else shows <<alert("Developer: for 
lookups to work you must provide a form name!")>>. I think we should still keep 
it. You could remove it in your custom application if you want. You will just 
lose the description but this is not a blocked.

Apart that I agree that it should works OOTB and my few tests where positive. 
So I think I will commit your patch but will keep the form name check OOTB.
                
> renderLookupField macro: get a form element by "ID" instead of "Name"
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-4926
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4926
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: lookup.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hello all,
> We have a problem to render a lookup field in a form element without a "name" 
> attribute.
> We need to improve a lookup field because if we render the field without form 
> or different form then the lookup field doesn't work, so we will change the 
> lookup field by not get a from element by a "name" attribute but get by an 
> "id" attribute.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to