[ 
https://issues.apache.org/jira/browse/OFBIZ-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290858#comment-13290858
 ] 

Jacques Le Roux commented on OFBIZ-4926:
----------------------------------------

Jacopo,

Actually, I'm still reluctant to commit. That's why I did not this morning. 
After an hour of review and test, I'm convinced that it will continue to work 
well with this patch, if we keep the form name check OOTB. Chatree could then 
remove it from his appplications. Reviews and tests are always welcome.

Chatree,

As Japoco outlined, it introduces a risk and for now I prefer to put this aside 
because it adds not much benefits. In which cases do you need to have a loopud 
field outside of a form? Can't you then use a dummy form?
                
> renderLookupField macro: get a form element by "ID" instead of "Name"
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-4926
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4926
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 10.04
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: lookup.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hello all,
> We have a problem to render a lookup field in a form element without a "name" 
> attribute.
> We need to improve a lookup field because if we render the field without form 
> or different form then the lookup field doesn't work, so we will change the 
> lookup field by not get a from element by a "name" attribute but get by an 
> "id" attribute.
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to