To better explain what I think is the best way to go: 1) Hans reverts all the changes introduced with the "security" reader: the initial ones and all the subsequent fixes for the problems caused by them 2) Hans submits a patch with all the changes in their final (tested) version to Jira 3) we all review them and share thoughts 4) if needed we improve/modify the solution 5) when an agreement is found the work is committed
Jacopo On Jun 16, 2012, at 8:47 PM, Jacopo Cappellato wrote: > At the moment I am more inclined to ask you to stop and revert the work on > "security" group... but I would like others to comment as well. > Then we will discuss the changes but we will have more time because the > system will work as it used to before your changes. So no, please do not > consider silence as an ok to proceed with your plan to fix the issues you > introduced... what I see is that the other committers do not fully understand > your design or do not like it and this clearly needs to be discussed. > > Jacopo > > > On Jun 16, 2012, at 1:28 PM, Hans Bakker wrote: > >> If i do not hear any objections against the creation of a SYSTEM (seed) >> security group with a userLoginId 'system' then i will try commit that >> tomorrow in order to solve the outstanding problem when only seed/extseed is >> loaded. >> >> Hans >> >> On 06/16/2012 03:33 PM, Hans Bakker wrote: >>> with ant load-seed an load-extseed by default the component security is not >>> loaded, if you want the same situation as before you have to load security >>> with ./ant load-readers -Ddata-readers=security or load load a specifc >>> component security file. >>> >>> When security is not loaded the component will be not be shown to any user >>> including the admin users of the system. >>> >>> A similar message as above is shown at the end of the load seed/extseed >>> command >>> >>> Regards, >>> Hans >>> >>> On 06/16/2012 03:21 PM, Jacques Le Roux wrote: >>>> In which cases the component security is not loaded? >>>> >>>> Jacques >>>> >>>> From: "Hans Bakker" <[email protected]> >>>>> Implementing the 'SYSTEM' security group will let the userlogin 'system' >>>>> work exactly the same as now with the addition that it even will work >>>>> when the component security is not loaded. >>>>> >>>>> Hans >>>>> >>>>> On 06/16/2012 02:45 PM, Jacques Le Roux wrote: >>>>>> Ha, Hans, I did not notice your answer on the *dev ML* because I user >>>>>> filter to separate Jira issues from emails direct to dev ML >>>>>> Please keep your Jira comments in Jira. >>>>>> >>>>>> So I answered to Jacopo's question about the situation. Would be good to >>>>>> clarify the situation in this thread and not mix Jira comments :/ >>>>>> >>>>>> OK too late then: >>>>>> At first glance I see any problems with the >>>>>>> I propose here a new general 'FULLADMIN' security group called 'SYSTEM' >>>>>>> which is only used for the 'system' userlogin. >>>>>> >>>>>> We find always ourseleves with the need to use the system user for >>>>>> specific services calls anyway. >>>>>> >>>>>> Not sure it answer all Jacop's question in the other thread though, or >>>>>> is rather a new try/test to complete initial work... >>>>>> >>>>>> Jacques >>>>>> >>>>>> From: "Hans Bakker" <[email protected]> >>>>>>> Ok most these problems are solved now. added warning messages to ./ant >>>>>>> seed and ./ant extseed >>>>>>> >>>>>>> Still, like in assetmaintenance the background jobs need full access to >>>>>>> the assetmaint component however it could be that the security is not >>>>>>> loaded. >>>>>>> >>>>>>> I propose here a new general 'FULLADMIN' security group called 'SYSTEM' >>>>>>> which is only used for the 'system' userlogin. >>>>>>> >>>>>>> This will allow the system userlogin to run any background process and >>>>>>> every component can give 'admin' privileges to the SYSTEM security >>>>>>> permissiongroup in the seed data. Then the background will run even if >>>>>>> the standard security is not loaded. >>>>>>> >>>>>>> Let me know of any comments or other suggestions for this problem >>>>>>> >>>>>>> Regards, >>>>>>> Hans >>>>>>> >>>>>>> >>>>>>> On 06/14/2012 04:47 PM, Jacopo Cappellato (JIRA) wrote: >>>>>>>> [ >>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>>>>>>> ] >>>>>>>> >>>>>>>> Jacopo Cappellato reassigned OFBIZ-4936: >>>>>>>> ---------------------------------------- >>>>>>>> >>>>>>>> Assignee: Hans Bakker >>>>>>>> >>>>>>>> Hans, I think this is related to the recent refactoring ("security" >>>>>>>> reader), could you please have a look and fix it? >>>>>>>> If you are not available, just reassign to me and I will try to have a >>>>>>>> look and fix the code. >>>>>>>> >>>>>>>>> Installation error occur about JobSandbox >>>>>>>>> ----------------------------------------- >>>>>>>>> >>>>>>>>> Key: OFBIZ-4936 >>>>>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-4936 >>>>>>>>> Project: OFBiz >>>>>>>>> Issue Type: Bug >>>>>>>>> Components: ALL COMPONENTS >>>>>>>>> Affects Versions: SVN trunk >>>>>>>>> Environment: Mac OS X Lion 1.7.4 >>>>>>>>> Oracle Java SDK 1.7 >>>>>>>>> Apache OFBiz trunk Rev: 1350081 >>>>>>>>> Reporter: Thanakrit Wongyued >>>>>>>>> Assignee: Hans Bakker >>>>>>>>> Attachments: Terminal Saved Output.log >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> My name is Thanakrit from Thailand. I try to install ofbiz from trunk >>>>>>>>> and then error occured reading data from file below : >>>>>>>>> trunk/applications/accounting/data/AccountingScheduledServiceData.xml >>>>>>>>> trunk/framework/service/data/ScheduledServices.xml >>>>>>>>> and more... >>>>>>>>> [java] 2012-06-14 14:23:26,771 (main) [ >>>>>>>>> EntitySaxReader.java:220:INFO ] Beginning import from URL: >>>>>>>>> file:/Users/Thanakrit/Projects/srk/trunk/framework/service/data/ScheduledServices.xml >>>>>>>>> [java] 2012-06-14 14:23:26,771 (main) [ >>>>>>>>> EntitySaxReader.java:270:INFO ] Transaction Timeout set to 2 hours >>>>>>>>> (7200 seconds) >>>>>>>>> [java] 2012-06-14 14:23:26,870 (main) [ >>>>>>>>> GenericDelegator.java:891:ERROR] Failure in create operation for >>>>>>>>> entity [JobSandbox]: org.ofbiz.entity.GenericEntityException: Error >>>>>>>>> while inserting: [GenericEntity:JobSandbox][createdStamp,2012-06-14 >>>>>>>>> 14:23:26.829(java.sql.Timestamp)][createdTxStamp,2012-06-14 >>>>>>>>> 14:23:26.771(java.sql.Timestamp)][jobId,PURGE_OLD_JOBS(java.lang.String)][jobName,Purge >>>>>>>>> Old Jobs(java.lang.String)][lastUpdatedStamp,2012-06-14 >>>>>>>>> 14:23:26.829(java.sql.Timestamp)][lastUpdatedTxStamp,2012-06-14 >>>>>>>>> 14:23:26.771(java.sql.Timestamp)][maxRecurrenceCount,-1(java.lang.Long)][poolId,pool(java.lang.String)][runAsUser,system(java.lang.String)][runTime,2000-01-01 >>>>>>>>> >>>>>>>>> 00:00:00.0(java.sql.Timestamp)][serviceName,purgeOldJobs(java.lang.String)][tempExprId,MIDNIGHT_DAILY(java.lang.String)] >>>>>>>>> (SQL Exception while executing the following:INSERT INTO >>>>>>>>> OFBIZ.JOB_SANDBOX (JOB_ID, JOB_NAME, RUN_TIME, POOL_ID, STATUS_ID, >>>>>>>>> PARENT_JOB_ID, PREVIOUS_JOB_ID, SERVICE_NAME, LOADER_NAME, MAX_RETRY, >>>>>>>>> AUTH_USER_LOGIN_ID, RUN_AS_USER, RUNTIME_DATA_ID, RECURRENCE_INFO_ID, >>>>>>>>> TEMP_EXPR_ID, CURRENT_RECURRENCE_COUNT, MAX_RECURRENCE_COUNT, >>>>>>>>> RUN_BY_INSTANCE_ID, START_DATE_TIME, FINISH_DATE_TIME, >>>>>>>>> CANCEL_DATE_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, >>>>>>>>> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, >>>>>>>>> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table >>>>>>>>> 'JOB_SANDBOX' caused a violation of foreign key constraint >>>>>>>>> 'JOB_SNDBX_USRLGN' for key (system). The statement has been rolled >>>>>>>>> back.)). Rolling back transaction. >>>>>>>>> [java] 2012-06-14 14:23:26,871 (main) [ >>>>>>>>> TransactionUtil.java:379:WARN ] >>>>>>>>> [java] ---- exception report >>>>>>>>> ---------------------------------------------------------- >>>>>>>>> [java] [TransactionUtil.setRollbackOnly] Calling transaction >>>>>>>>> setRollbackOnly; this stack trace shows where this is happening: >>>>>>>>> [java] Exception: java.lang.Exception >>>>>>>>> [java] Message: Failure in create operation for entity >>>>>>>>> [JobSandbox]: org.ofbiz.entity.GenericEntityException: Error while >>>>>>>>> inserting: [GenericEntity:JobSandbox][createdStamp,2012-06-14 >>>>>>>>> 14:23:26.829(java.sql.Timestamp)][createdTxStamp,2012-06-14 >>>>>>>>> 14:23:26.771(java.sql.Timestamp)][jobId,PURGE_OLD_JOBS(java.lang.String)][jobName,Purge >>>>>>>>> Old Jobs(java.lang.String)][lastUpdatedStamp,2012-06-14 >>>>>>>>> 14:23:26.829(java.sql.Timestamp)][lastUpdatedTxStamp,2012-06-14 >>>>>>>>> 14:23:26.771(java.sql.Timestamp)][maxRecurrenceCount,-1(java.lang.Long)][poolId,pool(java.lang.String)][runAsUser,system(java.lang.String)][runTime,2000-01-01 >>>>>>>>> >>>>>>>>> 00:00:00.0(java.sql.Timestamp)][serviceName,purgeOldJobs(java.lang.String)][tempExprId,MIDNIGHT_DAILY(java.lang.String)] >>>>>>>>> (SQL Exception while executing the following:INSERT INTO >>>>>>>>> OFBIZ.JOB_SANDBOX (JOB_ID, JOB_NAME, RUN_TIME, POOL_ID, STATUS_ID, >>>>>>>>> PARENT_JOB_ID, PREVIOUS_JOB_ID, SERVICE_NAME, LOADER_NAME, MAX_RETRY, >>>>>>>>> AUTH_USER_LOGIN_ID, RUN_AS_USER, RUNTIME_DATA_ID, RECURRENCE_INFO_ID, >>>>>>>>> TEMP_EXPR_ID, CURRENT_RECURRENCE_COUNT, MAX_RECURRENCE_COUNT, >>>>>>>>> RUN_BY_INSTANCE_ID, START_DATE_TIME, FINISH_DATE_TIME, >>>>>>>>> CANCEL_DATE_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, >>>>>>>>> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, >>>>>>>>> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table >>>>>>>>> 'JOB_SANDBOX' caused a violation of foreign key constraint >>>>>>>>> 'JOB_SNDBX_USRLGN' for key (system). The statement has been rolled >>>>>>>>> back.)). Rolling back transaction. >>>>>>>>> [java] ---- stack trace >>>>>>>>> --------------------------------------------------------------- >>>>>>>> -- >>>>>>>> This message is automatically generated by JIRA. >>>>>>>> If you think it was sent incorrectly, please contact your JIRA >>>>>>>> administrators: >>>>>>>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >>>>>>>> >>>>>>>> For more information on JIRA, see: >>>>>>>> http://www.atlassian.com/software/jira >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>> >>> >> >
