Adam,

The tool used to minify CSS and JS files was removed in rev 1416358. Then the visual theme was partially updated to not use the minify tool. But that broke the theme, because the original commit to minify the Flat Grey theme was not completely reverted. This commit was necessary to complete the the revert.

-Adrian


On 12/11/2012 6:33 PM, Adam Heath wrote:
Er, no.  Please revert.  The correct fix is to update build.xml to
minimise these files.

On 12/11/2012 01:31 AM, jler...@apache.org wrote:
Author: jleroux
Date: Tue Dec 11 07:31:40 2012
New Revision: 1420019

URL: http://svn.apache.org/viewvc?rev=1420019&view=rev
Log:
Fixes "Flatgrey visual theme does not work"  
https://issues.apache.org/jira/browse/OFBIZ-5096 reported by Wai and pointed out by 
Adrian in dev ML

Modified:
     ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

Modified: ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml?rev=1420019&r1=1420018&r2=1420019&view=diff
==============================================================================
--- ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml (original)
+++ ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml Tue Dec 11 07:31:40 
2012
@@ -21,12 +21,12 @@ under the License.
  <entity-engine-xml>
      <VisualTheme visualThemeId="FLAT_GREY" visualThemeSetId="BACKOFFICE" 
description="Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_NAME" 
resourceValue="FLAT_GREY" sequenceId="01"/>
-    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" 
resourceValue="/flatgrey/maincss-min.css" sequenceId="01"/>
-    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" 
resourceValue="/flatgrey/javascript-min.css" sequenceId="02"/>
+    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" 
resourceValue="/flatgrey/maincss.css" sequenceId="01"/>
+    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_STYLESHEET" 
resourceValue="/flatgrey/javascript.css" sequenceId="02"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HELPSTYLESHEET" 
resourceValue="/flatgrey/help.css" sequenceId="01"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_DOCBOOKSTYLESHEET" 
resourceValue="/flatgrey/webapp/flatgrey/docbook.css" sequenceId="01"/>
-    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" 
resourceValue="/flatgrey/mainrtl-min.css" sequenceId="01"/>
-    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" 
resourceValue="/flatgrey/js/application-min.js" sequenceId="01"/>
+    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_RTL_STYLESHEET" 
resourceValue="/flatgrey/mainrtl.css" sequenceId="01"/>
+    <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_JAVASCRIPT" 
resourceValue="/flatgrey/js/application.js" sequenceId="01"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_SHORTCUT_ICON" 
resourceValue="/images/ofbiz.ico" sequenceId="01"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_IMAGE_URL" 
resourceValue="/flatgrey/images/ofbiz_logo.gif" sequenceId="01"/>
      <VisualThemeResource visualThemeId="FLAT_GREY" resourceTypeEnumId="VT_HDR_TMPLT_LOC" 
resourceValue="component://flatgrey/includes/header.ftl" sequenceId="01"/>



Reply via email to