On 12/12/2012 01:34 PM, Jacques Le Roux wrote: > Adam Heath wrote: >> On 12/11/2012 08:25 PM, Adrian Crum wrote: >>> The tool used to minify CSS and JS files was removed in rev 1416358. >>> Then the visual theme was partially updated to not use the minify >>> tool. But that broke the theme, because the original commit to minify >>> the Flat Grey theme was not completely reverted. This commit was >>> necessary to complete the the revert. >> >> Oh, missed that. Why don't we want to minify things anymore, if you >> don't mind me asking? > > Because it collides with Birt > http://svn.apache.org/viewvc?view=revision&revision=1416364
Ok, then I disagree. So what if using yuicompressor on birt causes birt to break. That's birt's problem, or yuicompressor's problem. If it works fine with ofbiz files(or ofbiz files can be changed to make it work), then why not use it? It reduces the size of the files, and in some cases, makes client-side parsing faster. I'd remove birt(tbh, it's too big, too intrusive), and re-add yuicompressor.
