+1, I'd also like to hear more about the motivations behind this change.

Thanks
Scott

On 19/03/2013, at 2:13 AM, Paul Foxworthy wrote:

> One more...
> 
> Is the ProductStore the right place for the new option? Could it be viewed
> as a compliance matter required by a TaxAuthority? In other words, should
> the option be defined in TaxAuthorityRateProduct, and not the ProductStore?
> 
> Thanks
> 
> Paul Foxworthy
> 
> 
> Paul Foxworthy wrote
>> Hans,
>> 
>> I am not clear on the need for r1449615
>> (https://fisheye6.atlassian.com/changelog/ofbiz?cs=1449615).
>> 
>> The commit adds an option calcTaxAfterPromotion to the ProductStore. I
>> assume the idea is that tax could be calculated either before or after a
>> promotional adjustments to a price. But, we already have the capability in
>> TaxAuthorityRateProduct to say that tax should be applied to promotional
>> adjustments. Would that achieve the same goal? Is there another reason for
>> the change I have missed?
>> 
>> I do not understand why the new behaviour only happens when the quantity
>> ordered is one. Can you explain please?
>> 
>> Was there a Jira for this change?
>> 
>> Thanks
>> 
>> Paul Foxworthy
> 
> 
> 
> 
> 
> -----
> --
> Coherent Software Australia Pty Ltd
> http://www.coherentsoftware.com.au/
> 
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
> 
> --
> View this message in context: 
> http://ofbiz.135035.n4.nabble.com/More-detail-on-r1449615-please-tp4639907p4639908.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Reply via email to