[ 
https://issues.apache.org/jira/browse/OFBIZ-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686564#comment-13686564
 ] 

Jacques Le Roux commented on OFBIZ-5220:
----------------------------------------

Sorry Skip,

I will not commit it, because request-redirect works well without and David's 
intent was clearly to avoid putting forms fields parameters/values in the URL 
(obvious for sensitive data and text-area).

You can check it works well. In trunk demo try to add a new party for instance 
you get to the party profile view with all data but a clean url.

So I will rather change the documentation in XSD. What we could to is to create 
a request-redirect-allparam like we have request-redirect-noparam

BTW you removed a test on query string emptyness. I added it in a new patch 
which could used as a ref. to create request-redirect-allparam
                
> request-redirect does not pass all parameters if none are specified with 
> response-parameter
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5220
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5220
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Skip Dever
>         Attachments: OFBIZ-5220 - request-redirect does not pass all 
> parameters if none are specified with response-parameter.patch, OFBIZ-5220 - 
> request-redirect does not pass all parameters if none are specified with 
> response-parameter.patch, RequestHandler.java
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The xsd documentation says "Automatically redirect all current request 
> parameters to the new request or only redirected ..."
> This is broken.  If you specify a request-redirect from a form (where the 
> parameters are not in the url), these parameters are not passed on to the 
> redirected url. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to