This is indeed a concern. I believe we should always all follow the Jira way of sharing and testing before committing any new major feature or major bug fix (not trivial ones of course). Then, it's possible to wait few days for others to check, not bullet proof but surely better.
Jacques Hans Bakker wrote: > If you would have announced this before you implemented it, i would have > known, now in first instance we think this is caused by our changes..... > And only later check the svn updates.... > > Regards, > Hans > > Try entering a purchase invoice: > > Expected collection or sequence. parameterList evaluated instead to > freemarker.template.SimpleScalar on line 51, column 12 in > component://widget/templates/htmlMenuMacroLibrary.ftl. The problematic > instruction: ---------- ==> list parameterList as parameter [on line 51, > column 5 in component://widget/templates/htmlMenuMacroLibrary.ftl] in > user-directive renderLink [on line 1, column 1 in > org.ofbiz.widget.menu.MacroMenuRenderer@21cc9647_1074] ---------- Java > backtrace for programmers: ---------- > freemarker.template.TemplateException: Expected collection or sequence. > parameterList evaluated instead to freemarker.template.SimpleScalar on > line 51, column 12 in > component://widget/templates/htmlMenuMacroLibrary.ftl. at > freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:136) > at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock. > > try entering a new accounting transaction: > https://localhost:8443/accounting/control/createAcctgTrans > > Expected collection or sequence. parameterList evaluated instead to > freemarker.template.SimpleScalar on line 51, column 12 in > component://widget/templates/htmlMenuMacroLibrary.ftl. The problematic > instruction: ---------- ==> list parameterList as parameter [on line 51, > column 5 in component://widget/templates/htmlMenuMacroLibrary.ftl] in > user-directive renderLink [on line 1, column 1 in > org.ofbiz.widget.menu.MacroMenuRenderer@6e5faa56_1073] ---------- Java > backtrace for programmers: ---------- > freemarker.template.TemplateException: Expected collection or sequence. > parameterList evaluated instead to freemarker.template.SimpleScalar on > line 51, column 12 in > component://widget/templates/htmlMenuMacroLibrary.ftl. at > > and at a number of other places...... > > Regards, > Hans > > > > > On 08/27/2013 11:44 AM, Adrian Crum wrote: >> No one is asking you to fix anything. All you had to do was post a >> message and I would have fixed it. >> >> There was nothing blocking about my commit, and as I said there was no >> reason to revert it. >> >> Reverting a commit the way you did is NOT co-operation, and >> co-operation is a concept you consistently fail to understand. >> >> -Adrian >> >> On 8/26/2013 8:47 PM, Hans Bakker wrote: >>> Adrian, >>> Normally I would try to fix a problem and i did this pretty often. >>> Because this was a blocking problem i saw no other way then to revert >>> it. >>> >>> Very good to hear you like my commits which at least make a >>> difference for our end users. Although i personally appreciate your >>> framework commits, end-users, which are out bread and butter, are >>> mostly not aware of it. >>> >>> good to co-operate with you, your comments are often very helpful, >>> keep up the good work! >>> >>> Regards, >>> Hans >>> >>> >>> On 08/26/2013 03:47 PM, Adrian Crum wrote: >>>> Hans, >>>> >>>> Normally, we report problems on the mailing list, not revert someone >>>> else's commit. >>>> >>>> This was rude and uncalled for. If I did the same thing to your >>>> buggy commits, none of your contributions would make it into the >>>> project. >>>> >>>> -Adrian >>>> >>>> On 8/25/2013 11:28 PM, hans...@apache.org wrote: >>>>> Author: hansbak >>>>> Date: Mon Aug 26 06:28:00 2013 >>>>> New Revision: 1517434 >>>>> >>>>> URL: http://svn.apache.org/r1517434 >>>>> Log: >>>>> revert r1517353: it makes the tomahawk theme unusable >>>>> >>>>> Removed: >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MacroMenuRenderer.java >>>>> >>>>> ofbiz/trunk/framework/widget/templates/htmlMenuMacroLibrary.ftl >>>>> Modified: >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java >>>>> >>>>> >>>>> Modified: >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java >>>>> URL: >>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java?rev=1517434&r1=1517433&r2=1517434&view=diff >>>>> ============================================================================== >>>>> >>>>> --- >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java >>>>> (original) >>>>> +++ >>>>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java >>>>> Mon Aug 26 06:28:00 2013 >>>>> @@ -38,10 +38,8 @@ import org.ofbiz.webapp.view.AbstractVie >>>>> import org.ofbiz.webapp.view.ViewHandlerException; >>>>> import org.ofbiz.widget.form.FormStringRenderer; >>>>> import org.ofbiz.widget.form.MacroFormRenderer; >>>>> -import org.ofbiz.widget.menu.MacroMenuRenderer; >>>>> -import org.ofbiz.widget.menu.MenuStringRenderer; >>>>> -import org.ofbiz.widget.tree.MacroTreeRenderer; >>>>> import org.ofbiz.widget.tree.TreeStringRenderer; >>>>> +import org.ofbiz.widget.tree.MacroTreeRenderer; >>>>> import org.xml.sax.SAXException; >>>>> import freemarker.template.TemplateException; >>>>> @@ -92,13 +90,15 @@ public class MacroScreenViewHandler exte >>>>> ScreenStringRenderer screenStringRenderer = new >>>>> MacroScreenRenderer(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".name"), UtilProperties.getPropertyValue("widget", >>>>> getName() + ".screenrenderer")); >>>>> FormStringRenderer formStringRenderer = new >>>>> MacroFormRenderer(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".formrenderer"), request, response); >>>>> TreeStringRenderer treeStringRenderer = new >>>>> MacroTreeRenderer(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".treerenderer"), writer); >>>>> - MenuStringRenderer menuStringRenderer = new >>>>> MacroMenuRenderer(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".menurenderer"), request, response); >>>>> + // TODO: uncomment these lines when the renderers are >>>>> implemented >>>>> + //MenuStringRenderer menuStringRenderer = new >>>>> MacroMenuRenderer(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".menurenderer"), writer); >>>>> ScreenRenderer screens = new ScreenRenderer(writer, >>>>> null, screenStringRenderer); >>>>> screens.populateContextForRequest(request, response, >>>>> servletContext); >>>>> + // this is the object used to render forms from their >>>>> definitions >>>>> screens.getContext().put("formStringRenderer", >>>>> formStringRenderer); >>>>> screens.getContext().put("treeStringRenderer", >>>>> treeStringRenderer); >>>>> - screens.getContext().put("menuStringRenderer", >>>>> menuStringRenderer); >>>>> + //screens.getContext().put("menuStringRenderer", >>>>> menuStringRenderer); >>>>> screens.getContext().put("simpleEncoder", >>>>> StringUtil.getEncoder(UtilProperties.getPropertyValue("widget", >>>>> getName() + ".encoder"))); >>>>> screenStringRenderer.renderScreenBegin(writer, >>>>> screens.getContext()); >>>>> screens.render(page);
