[ 
https://issues.apache.org/jira/browse/OFBIZ-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789198#comment-13789198
 ] 

Jacques Le Roux commented on OFBIZ-5250:
----------------------------------------

It's an interesting feature, I have no problems with it. 

I'd just change 
comments="DemoCustAgent is a Sales Representative for DemoCustCompany (will be 
automatically to an order)"/>
comments="DemoCustAgent is a Sales Representative for DemoCustCompany (will be 
automatically added to a sales order in demo)"/>

Also, like recurse and useCache, includeFromToSwitched parameter is optional in 
getRelatedParties service and defaults to "N" so could be removed (the same 
could be done in BillingAccountWorker.makePartyBillingAccountList() BTW). The 
less distractions we get the better...

> Support for assigning a sales representative to a custome/order
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-5250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5250
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, party
>    Affects Versions: SVN trunk
>            Reporter: Christian Geisert
>         Attachments: ofbiz_sales_rep_order-20130628.diff
>
>
> This change adds a new PartyRelationshipType "SALES_REP":
> {{<PartyRelationshipType description="" hasTable="N" parentTypeId="" 
> partyRelationshipName="Sales Representative" 
> partyRelationshipTypeId="SALES_REP" roleTypeIdValidFrom="" 
> roleTypeIdValidTo="SALES_REP"/>}}
> When creating an order the sales rep will be added as additional party role 
> to the shopping cart and then could be changed/removed on the "Additional 
> Party Entry" screen while finalizing the order.
> You can use DemoCustCompany for testing (added as Demodata)
> I'd like to have a review before committing.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to