[ 
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799769#comment-13799769
 ] 

Sebastian Wachinger edited comment on OFBIZ-5312 at 10/19/13 3:59 AM:
----------------------------------------------------------------------

I am on of those -lunatics- brave souls not only using _trunk_ in production 
sites, but also daring to try out and test patches like the one discussed right 
here, because I really want to use this important feature asap. After all, 
having perfect URLs is a key requirement.

So what I would like to know is:
(?) Can this here patch coexist with the solution aka 
[CatalogUrlFilter|http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=1127449]
 introduced by Hans, or does it break anything?

For now I would like to continue using _CatalogUrlFilter_ in one existing 
ecommerce app, and try Paul's solution in another new ecommerce app on the same 
OFBiz system (of course each with its respectively tailored _web.xml_).

_Full disclosure:_ I am doing this on our own projects, not for those of our 
clients, so the well earned reputation of the great OFBiz framework won't get 
tarnished either way.



was (Author: komdata):
I am on of those -lunatics- brave souls not only using _trunk_ in production 
sites, but also daring to try out and test patches like the one discussed right 
here, because I really want to use this important feature asap. After all, 
having perfect URLs is a key requirement.

(?) So what I would like to know is:
Can this here patch coexist with the solution aka 
[CatalogUrlFilter|http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=1127449]
 introduced by Hans, or does it break anything?

For now I would like to continue using _CatalogUrlFilter_ in one existing 
ecommerce app, and try Paul's solution in another new ecommerce app on the same 
OFBiz system (of course each with its respectively tailored _web.xml_).

_Full disclosure:_ I am doing this on our own projects, not for those of our 
clients, so the well earned reputation of the great OFBiz framework won't get 
tarnished either way.


> Proposal: URL-Generation Changes
> --------------------------------
>
>                 Key: OFBIZ-5312
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5312
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: changes, ecommerce, friendly, seo, url
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - 
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, 
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, SeoContextFilter.java.patch
>
>
> [This was proposed by Paul Piper in Nabble 7 months 
> ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html].
>  Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz 
> changes that we believe the entire community could benefit from. The changes 
> have been implemented in parts in Syracus (www.syracus.net) for a while now, 
> but we figured that some of which are too crucial for ofbiz' success in the 
> long run, so we are considering the contribution (as we did with the SOLR 
> component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating 
> URLs. Most of this has to do with the fact that OFBiz uses a servlet 
> (ControlServlet)  to handle all requests. The servlet is mounted at /control, 
> so that it won't interfere with other servlets. Though functionally valid, 
> this has the sideeffect that all urls are actually created on /control, which 
> is neither pretty, nor good by any measures of SEO. It also means that a few 
> 302 redirects are necessary to forward the user from / to /control/main. It 
> also makes requests more complicated, since many forwards are necessary 
> whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss 
> whether or not you guys would be interested in the changes we have made. The 
> functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms, 
> Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few 
> minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul 
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even 
> if it has been already used in [Syracus|http://syracus.net/] since early this 
> year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a 
> /control/ or /main by default in ecommerce urls? Would you not prefer 
> http://localhost:8080/ecommerce/ over 
> http://localhost:8080/ecommerce/control/main ?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to