[ 
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815779#comment-13815779
 ] 

Sebastian Wachinger edited comment on OFBIZ-5312 at 11/7/13 9:01 AM:
---------------------------------------------------------------------

Hi Jacques,

I guess you are right, let's just keep the names of categories, products and 
product IDs the way they are defined in the catalog, no need really to meddle 
here with upper/lower case.

The _.html_ suffix . . . well, sometimes you end up publishing deep links to a 
product page on places like a facebook page, and maybe it's indeed just a 
matter of taste, but for my liking URLs look better without geeky stuff like 
file extensions that carry no meaning to the average user without technical 
background.
And of course we introduce another error source, now what was it again, _.html_ 
or _.htm_ . . . SEO-wise it doesn't matter anyway.


I think it probably might be a good idea to quote the latest comment from Paul 
on [OFBIZ-4535|https://issues.apache.org/jira/browse/OFBIZ-4535] in this thread 
as well:

bq. So now upper and lower case both work, and the _product_ bit can be used or 
not or be replaced at will?

{quote}
that is indeed less than ideal. It probably derives from the fact that only the 
productId/categoryId is evaluated in the url structure, and not the rest of the 
string. It probably isn't "too dangerous" if the generated URL is kept the 
same, but it is risky and not ideal to say the least. If we do not want to 
implement a url database on an entity level, i would propose to build a simple 
filter that:

1. Looks up request URL
2. Identifies productid/categoryid/catalogid/contentid in the string
3. Uses the generator to generate a new request url
4. matches both, the generated string and the request url and does a request 
redirect if they don't match... 
{quote}


was (Author: komdata):
Hi Jacques,

I guess you are right, let's just keep the names of categories, products and 
product IDs the way they are defined in the catalog, no need really to meddle 
here with upper/lower case.

The _.html_ suffix . . . well, sometimes you end up publishing deep links to a 
product page on places like a facebook page, and maybe it's indeed just a 
matter of taste, but for my liking URLs look better without geeky stuff like 
file extensions that carry no meaning to the average user without technical 
background.
And of course we introduce another error source, now what was it again, _.html_ 
or _.htm_ . . . SEO-wise it doesn't matter anyway.


I think it probably might be a good idea to quote the latest comment from Paul 
on [OFBIZ-4535|https://issues.apache.org/jira/browse/OFBIZ-4535] in this thread 
as well:

bq. So now upper and lower case both work, and the _product_ bit can be used or 
not or be replaced at will.

{quote}
that is indeed less than ideal. It probably derives from the fact that only the 
productId/categoryId is evaluated in the url structure, and not the rest of the 
string. It probably isn't "too dangerous" if the generated URL is kept the 
same, but it is risky and not ideal to say the least. If we do not want to 
implement a url database on an entity level, i would propose to build a simple 
filter that:

1. Looks up request URL
2. Identifies productid/categoryid/catalogid/contentid in the string
3. Uses the generator to generate a new request url
4. matches both, the generated string and the request url and does a request 
redirect if they don't match... 
{quote}

> Proposal: URL-Generation Changes
> --------------------------------
>
>                 Key: OFBIZ-5312
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5312
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: changes, ecommerce, friendly, seo, url
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - 
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, 
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - 
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, 
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - 
> ofbiz-ecommerce-seo.patch, OFBiz-5312-product-ecommerce-seo-20131031.patch, 
> OFBiz-5312-product-ecommerce-seo-for-seo-branch.patch, 
> OFBiz-5312-product-ecommerce-seo.patch, SeoContextFilter.java.patch
>
>
> [This was proposed by Paul Piper in Nabble 7 months 
> ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html].
>  Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz 
> changes that we believe the entire community could benefit from. The changes 
> have been implemented in parts in Syracus (www.syracus.net) for a while now, 
> but we figured that some of which are too crucial for ofbiz' success in the 
> long run, so we are considering the contribution (as we did with the SOLR 
> component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating 
> URLs. Most of this has to do with the fact that OFBiz uses a servlet 
> (ControlServlet)  to handle all requests. The servlet is mounted at /control, 
> so that it won't interfere with other servlets. Though functionally valid, 
> this has the sideeffect that all urls are actually created on /control, which 
> is neither pretty, nor good by any measures of SEO. It also means that a few 
> 302 redirects are necessary to forward the user from / to /control/main. It 
> also makes requests more complicated, since many forwards are necessary 
> whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss 
> whether or not you guys would be interested in the changes we have made. The 
> functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms, 
> Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few 
> minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul 
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even 
> if it has been already used in [Syracus|http://syracus.net/] since early this 
> year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a 
> /control/ or /main by default in ecommerce urls? Would you not prefer 
> http://localhost:8080/ecommerce/ over 
> http://localhost:8080/ecommerce/control/main ?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to