[
https://issues.apache.org/jira/browse/OFBIZ-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939110#comment-13939110
]
Pierre Smits commented on OFBIZ-5532:
-------------------------------------
Christian,
I tried to assess your patch in a clean checkout of trunk, but it generated
errors in:
* applications/manufacturing/config/ManufacturingUiLabels.xml
* applications/manufacturing/servicedef/services_production_run.xml
* applications/manufacturing/webapp/manufacturing/WEB-INF/controller.xml
* applications/manufacturing/widget/manufacturing/ProductionRunForms.xml
* applications/product/config/ProductEntityLabels.xml
* applications/product/config/ProductErrorUiLabels.xml
* applications/product/config/ProductUiLabels.xml
* applications/workeffort/widget/TimesheetMenus.xml
Did you perform an 'Update to Head' action in your development tool before
generating the patch? That might resolve the issues mentioned above.
Furthermore, you combined the modifications relating to several JIRA issues
into one big patch (as per your explanation). However, it would be better to
not do this. When you create your patch file to only resolve the issue at hand,
it will enable faster evaluation and and better impact analysis. Thus, when
questions arise regarding your patch, the discussion will not be diluted with
aspects of the other JIRA issues.
It also ensures that when your patch is included in any branch and it must be
reverted due to some unforseen error in one area, the good stuff from your
patch needn't be reverted too.
Regards,
Pierre
> Improve production run task declarations to create time entries for each
> declaration
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-5532
> URL: https://issues.apache.org/jira/browse/OFBIZ-5532
> Project: OFBiz
> Issue Type: Improvement
> Components: manufacturing
> Affects Versions: SVN trunk
> Reporter: Christian Carlow
> Attachments: OFBIZ-5532.patch, OFBIZ-5532.patch
>
>
> Timesheet entries are supposed to be created when produced and rejected
> quantities are declared for production run tasks.
> ProductionRunServices.updateProductionRunTask accepts the partyId as a
> parameter but code that is supposed to use it to create timesheet entries has
> been commented out. Rev 910230 shows that the commented code has always
> existed. There are also FIXME comments to add quantityProduced,
> quantityRejected, and setupTime fields to the timesheet entity.
> This functionality is vital for determining which employees are responsible
> for rejects.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
