[ 
https://issues.apache.org/jira/browse/OFBIZ-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255723#comment-14255723
 ] 

Jacques Le Roux commented on OFBIZ-5704:
----------------------------------------

Would it not be possible to have both solutions? 

In case an user wants the simple solution Pierre suggest, which I agree seems 
the most possible case, then she would simply use the Lot.partyId. If she needs 
to relate the lot to more parties, then she would pick Adrian's recommended 
pattern. Since Adrian did not provide a patch yet, we could already apply 
Pierre's patch with a clear documentation on when to pick this use case 
contrary to the other possible use case. The same user could even use both 
cases depending on circumstances. 

Though Scott mentionned
{code}
The reason not to is because the data model is a pain to change if we later 
decide we need to be able to assign more parties to a Lot.
{code}
I don't see a problem with that as long as it's clearly documented in the data 
model and in possible related code (not there yet). We can let open the 2 
possibilites and pick the one we need when we want. But it needs to be 
documented in both the source and the wiki, with a reference from the source to 
the wiki.

Sharan could even put it, as a warning, in the next release of her book :)

> Extend lot entity to include party Id of manufacturer
> -----------------------------------------------------
>
>                 Key: OFBIZ-5704
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5704
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing, product, workeffort
>    Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>            Reporter: Pierre Smits
>         Attachments: OFBiz-5704-Product-EntityModel-Lot.patch, Screen Shot 
> 2014-09-03 at 13.52.47.png
>
>
> Rationale
> Lot or batch management affects two places, namely the outbound process (and 
> its functionalities) and inbound. 
> It is possible that multiple parties have the same ID for the batch or the 
> lot. Howver, in current feature set there is no discrimination between lots 
> from supplier A, supplier B, or even the primary (internal) company in OFBiz.
> Therefore the entity 'Lot' should be extended with another key, namely that 
> of the partyId of the manufacturer (or supplier).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to