The patch added to the framework could just as easily be captured in the intended component, extending the ModelTestSuite.java file. That way the component works fairly independent and when users don't want this they won't have superfluous code in their implementation. While I agree that testing is important, users can easily pull the code from the antweb repos and work from there, so there is actually no need to bundle it into the OFBiz code base. This is something one wouldn't use in a production environment (unless testing is your business).
Best regards, Pierre Smits *OFBiz Extensions Marketplace* http://oem.ofbizci.net/oci-2/ On Fri, Oct 23, 2015 at 9:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Hans, inline > > Le 23/10/2015 07:23, Hans Bakker a écrit : > >> Hi Jacques, thanks for bringing this up. >> >> 1. this changes in the framework is a pretty general one, any external >> test system can use it. It is not specific for the component we provided. >> It is actually just an example that Ruud created, on how you can use this >> 'hook'. Yes the change is not more than a 'hook' >> > > Agreed > > 2. We should implement more of these kind of hooks. I have another one: >> Did you ever try to create a component with its own menu system? We have >> the growerp backend as an example how to do that. Is the community >> interested in this menu hook? >> > > I guess, to be interested we should have some code to see, why not > creating a Jira? > > 3. Further, this growerptest component we provide is not a work in >> progress any more, it has the apache 2 license, can be included into ofbiz >> if you want, and as I said before, i can even provide peer-write access to >> the component for people who want to contribute. >> > > Thanks for the proposition, I'm all for including it as a spercialpurpose > component. Being in OFBiz OOTB is the more visible place for everyone and > the more appealing for contributions > > I closed the still opened remaining Selenium related OFBIZ-4189 and > OFBIZ-3438 issues. > I think we should replace > https://cwiki.apache.org/confluence/display/OFBIZ/Pure+webdriver+implementation > by the now common README + wiki page scheme we have in (some) other > components. > > Jacques > > > >> If you have any further questions, let me know. >> >> Regards, Hans >> >> On 22/10/15 14:11, Jacques Le Roux wrote: >> >>> Hi, >>> >>> There is a WIP in the GrowErp community on a growerptest Selenium >>> component, see https://issues.apache.org/jira/browse/OFBIZ-6618 >>> >>> The commit r1709516 introduced a small change to have it working OOTB >>> when you put it in hot-deploy >>> >>> The question is: do we agree with this way of doing and let the GrowErp >>> community handles the component out of OFBiz, or should we handle it >>> ourselves? >>> >>> Thanks for your opinions >>> >>> Jacques >>> >> >> >>
