Hello,
I arrive after the war but :)
This issue is interesting for many points and I keep :
* ModelTestSuite.java I'm afraid to see dead code, the call 'if
("webdriver-test".equals(nodeName)' will be never use for a standard
OFBiz and some new user won't understand why we call a non existent java
class. I understand that we can load from third part but ... if all
third community do the same way, how to maintain them in OFBiz without
making committer crazy ?
* I check the growerptest to control if it can be load on OFBiz
directly, but the code don't respect the coding convention and is
missing the minimum documentation like the xsd. I think it's really
interesting for the both community to improve the growerptest quality
** For OFBiz to have an other test case
** For GrowErp community to improve the code quality and minimize
the maintenance
I can read and try to improve the code but from grow erp do you want
participate to improve some part ?
Nicolas
Le 23/10/2015 07:23, Hans Bakker a écrit :
Hi Jacques, thanks for bringing this up.
1. this changes in the framework is a pretty general one, any external
test system can use it. It is not specific for the component we
provided. It is actually just an example that Ruud created, on how you
can use this 'hook'. Yes the change is not more than a 'hook'
2. We should implement more of these kind of hooks. I have another
one: Did you ever try to create a component with its own menu system?
We have the growerp backend as an example how to do that. Is the
community interested in this menu hook?
3. Further, this growerptest component we provide is not a work in
progress any more, it has the apache 2 license, can be included into
ofbiz if you want, and as I said before, i can even provide peer-write
access to the component for people who want to contribute.
If you have any further questions, let me know.
Regards, Hans
On 22/10/15 14:11, Jacques Le Roux wrote:
Hi,
There is a WIP in the GrowErp community on a growerptest Selenium
component, see https://issues.apache.org/jira/browse/OFBIZ-6618
The commit r1709516 introduced a small change to have it working OOTB
when you put it in hot-deploy
The question is: do we agree with this way of doing and let the
GrowErp community handles the component out of OFBiz, or should we
handle it ourselves?
Thanks for your opinions
Jacques
