[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284621#comment-15284621 ]
Jacques Le Roux edited comment on OFBIZ-6783 at 5/16/16 2:05 PM: ----------------------------------------------------------------- Sorry Taher, Still the same issue with _--testlist mode=ant_. Actually I believe it's not mandatory for now and could be fixed later. With the introduction of commons-cli-1.3.1.jar it's certainly a good idea to check parameters values. For instance, it's was not a big deal for me when I added the portoffset feature, but would be better to have it, I agree! BTW it's not even integers but roughly values < 2^16 (since port values vary and don't start from 0 the strict rule is hard to clearly establish and I'd not spent too much time on it ;)) was (Author: jacques.le.roux): Sorry Tather, Still the same issue with _--testlist mode=ant_. Actually I believe it's not mandatory for now and could be fixed later. With the introduction of commons-cli-1.3.1.jar it's certainly a good idea to check parameters values. For instance, it's was not a big deal for me when I added the portoffset feature, but would be better to have it, I agree! BTW it's not even integers but roughly values < 2^16 (since port values vary and don't start from 0 the strict rule is hard to clearly establish and I'd not spent too much time on it ;)) > Refactor the start component > ---------------------------- > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Upcoming Branch > Reporter: Taher Alkhateeb > Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)