[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290663#comment-15290663
]
Jacques Le Roux edited comment on OFBIZ-6783 at 5/19/16 8:11 AM:
-----------------------------------------------------------------
About
bq. java -jar ofbiz.jar --test component=minilang --test
Actually I was abused by this line in help
{code}
-t,--test <key=value> Runs the selected test or all if none
selected e.g.:
--test component=base --test case=somecase
--test component=base --test
suitename=somesuite
{code}
Could we not increase the width of the help?
was (Author: jacques.le.roux):
Actually I was abused by this line in help
bq. -t,--test <key=value> Runs the selected test or all if none
selected e.g.:
--test component=base --test case=somecase
--test component=base --test
suitename=somesuite
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
