I'm not familiar with the work Adrian did any subsequent work but I do believe the basis of the idea has merit. While there are some similarities between a form and a table, I think there are enough differences that it would be easier to move forward with new features specific to one or the other if they were separated.
Regards Scott On 16 March 2017 at 19:12, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > Thanks James, > > Here are some more elements to convince Taher that it was not a shoot in > the dark. > > They are all available from http://ofbiz.apache.org/releas > e-notes-16.11.01.html, just look for "grid" > > http://markmail.org/message/4m3vgq4wdvo7ziaj > > https://issues.apache.org/jira/browse/OFBIZ-6404 > > https://issues.apache.org/jira/browse/OFBIZ-6501 > > https://issues.apache.org/jira/browse/OFBIZ-6502 > > https://issues.apache.org/jira/browse/OFBIZ-7029 > > So it's not 100% done, but I don't see myself reverting all this work with > really good reasons! > > Jacques > > Le 15/03/2017 à 10:05, james yong a écrit : > >> Hi Taher, >> >> Common grid functionalities include pivots, sorting columns, multiple-row >> header, aggregate functions, in-grid editing etc. IMO, these should be >> standard grid features for modern ERP. I see the value of the extraction. >> It >> would be difficult to innovate in the future if lists are still coupled >> with >> forms. >> >> Regards, >> James Yong >> >> >> taher wrote >> >>> Still seems unclear. What is the value of this extraction? How is it >>> implemented? Who intends on implementing the new features if any? What >>> are >>> the new features? How does that play into the UI refactoring intended >>> within themes? What do we gain by this whole exercise? Given that we lost >>> Adrian, someone should have answers to these questions before we commit >>> to >>> such a large body of work. There are hundreds if not thousands of such >>> forms all over the code base. >>> >>> On Wed, Mar 15, 2017 at 11:29 AM, Pierre Smits < >>> pierre.smits@ >>> > >>> wrote: >>> >>> That is what you get in transitional stages. But then again, OFBiz offers >>>> lots of flexibility in order to get from A to Z. >>>> >>>> As I read it, it was the intention of Adrian to simplify (I would like >>>> to >>>> extract list functionality from the form widget and create a new grid >>>> widget). But you can't remove the functionality until all referenced >>>> widgets are converted (the backward compatibility). >>>> >>>> Best regards, >>>> >>>> Pierre Smits >>>> >>>> ORRTIZ.COM <http://www.orrtiz.com> >>>> OFBiz based solutions & services >>>> >>>> OFBiz Extensions Marketplace >>>> http://oem.ofbizci.net/oci-2/ >>>> >>>> On Wed, Mar 15, 2017 at 6:49 AM, Taher Alkhateeb < >>>> >>>> slidingfilaments@ >>> >>>> wrote: >>>>> So it's two widgets that output an identical HTML structure with no >>>>> >>>> plan >>>> in >>>> >>>>> sight of making a differentiation. This is now putting in the code base >>>>> >>>> two >>>> >>>>> ways of achieving the same thing (more complexity) for no added value. >>>>> Maybe we need to discuss the added value and direction of such work. >>>>> >>>>> On Tue, Mar 14, 2017 at 7:20 PM, Jacques Le Roux < >>>>> >>>>> jacques.le.roux@ >>> >>>> wrote: >>>> >>>>> Hi Taher, >>>>>> >>>>>> It's explained here http://markmail.org/message/77swtjvr6q25rq4d >>>>>> >>>>>> Quoting Adrian. >>>>>> >>>>>> <<Finally, I would like to extract list functionality from the >>>>>> >>>>> form >>>> >>> > > widget >>> >>>> and create a new grid widget. So, instead of a form widget >>>>>> >>>>> representing a >>>> >>>>> single data entry form OR a list, it will ONLY represent a single >>>>>> >>>>> form. >>>> >>>>> If >>>>> >>>>>> you want a list, you use the grid widget. Initially, this change will >>>>>> >>>>> be >>>> >>>>> backwards-compatible - the XML parser will accept a >>>>>> >>>>> <form> >>> element for >>> >>>> both >>>>> >>>>>> types and it will create the correct model based on the type >>>>>> >>>>> attribute.>> >>>> >>>>> Initially I wondered if Adrian had not a CSS idea in mind, I can't >>>>>> >>>>> clearly >>>>> >>>>>> remember if we discussed it or not >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> >>>>>> Le 14/03/2017 à 17:06, Taher Alkhateeb a écrit : >>>>>> >>>>>> Hi Jacques, >>>>>>> >>>>>>> What is the purpose of converting list forms to grids? >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Taher Alkhateeb >>>>>>> >>>>>>> On Mar 14, 2017 6:59 PM, < >>>>>>> >>>>>> jleroux@ >>> > wrote: >>> >>>> Author: jleroux >>>>>>> >>>>>>>> Date: Tue Mar 14 15:59:23 2017 >>>>>>>> New Revision: 1786919 >>>>>>>> >>>>>>>> URL: http://svn.apache.org/viewvc?rev=1786919&view=rev >>>>>>>> Log: >>>>>>>> Improved: refactor list related forms in Lookup widgets >>>>>>>> (OFBIZ-9232) >>>>>>>> >>>>>>>> Refactoring various list forms into grids >>>>>>>> Refactoring various list form references in screen widgets >>>>>>>> >>>>>>>> >>>>>>>> Thanks: Pierre Smits >>>>>>>> >>>>>>>> Modified: >>>>>>>> ofbiz/ofbiz-framework/trunk/applications/accounting/ >>>>>>>> widget/FieldLookupForms.xml >>>>>>>> ofbiz/ofbiz-framework/trunk/applications/accounting/ >>>>>>>> widget/LookupScreens.xml >>>>>>>> >>>>>>>> Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/ >>>>>>>> widget/FieldLookupForms.xml >>>>>>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ >>>>>>>> applications/accounting/widget/FieldLookupForms.xml? >>>>>>>> rev=1786919&r1=1786918&r2=1786919&view=diff >>>>>>>> ============================================================ >>>>>>>> ================== >>>>>>>> --- ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ >>>>>>>> FieldLookupForms.xml >>>>>>>> (original) >>>>>>>> +++ ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ >>>>>>>> FieldLookupForms.xml >>>>>>>> Tue Mar 14 15:59:23 2017 >>>>>>>> @@ -36,7 +36,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListLookupFixedAsset" list-name="listIt" title="" >>> > >>> type="list" paginate-target="LookupFixedAsset" >>> >>>> + >>>>>>>> >>>>>>> <grid name="ListLookupFixedAsset" list-name="listIt" title="" >>> > >>> paginate-target="LookupFixedAsset" >>> >>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -51,7 +51,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="fixedAssetName" title="${uiLabelMap. >>> > >>> CommonName}"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="fixedAssetTypeId" title="${uiLabelMap. >>> > >>> AccountingFixedAssetTypeId}"> >>> <display-entity >>> > >>> entity-name="FixedAssetType"/> >>> </field> >>> >>>> - >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>> </grid> >>> >>>> >>>>>>>> >>>>>>> <form name="LookupBudget" target="LookupBudget" title="" >>> > >>> type="single" >>> >>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> >>>>>>>> >>>>>>> <auto-fields-entity entity-name="Budget" >>> > >>> default-field-type="hidden"/> >>> >>>> @@ -94,7 +94,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListBillingAccount" list-name="listIt" title="" >>> > >>> type="list" paginate-target="LookupBillingAccount" >>> >>>> + >>>>>>>> >>>>>>> <grid name="ListBillingAccount" list-name="listIt" title="" >>> > >>> paginate-target="LookupBillingAccount" >>> >>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -110,7 +110,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="description"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="externalAccountId" title="${uiLabelMap. >>> > >>> AccountingExternalAccountId}"> >>> <display/> >>> </field> >>> >>>> - >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>> </grid> >>> >>>> >>>>>>>> >>>>>>> <form name="LookupGlAccount" target="LookupGlAccount" title="" >>> > >>> type="single" >>> >>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> @@ -134,7 +134,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListLookupGlAccount" list-name="listIt" title="" >>> > >>> type="list" paginate-target="LookupGlAccount" >>> >>>> + >>>>>>>> + >>>>>>>> >>>>>>> <form name="ListLookupGlAccount" list-name="listIt" title="" >>> > >>> paginate-target="LookupGlAccount" >>> >>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -151,6 +152,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="glAccountTypeId" >>> title="${uiLabelMap.CommonType >>> >>>> }"> >>>>>>>> >>>>>>> <display-entity >>> > >>> entity-name="GlAccountType"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="glAccountClassId" title="${uiLabelMap. >>> > >>> AccountingGlAccountClass}"> >>> <display-entity >>> > >>> entity-name="GlAccountClass"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>>> >>>>>>> <form name="LookupPayment" target="LookupPayment" title="" >>> > >>> type="single" >>> >>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> >>>>>>>> >>>>>>> <auto-fields-entity entity-name="Payment" >>> > >>> default-field-type="hidden"/> >>> >>>> @@ -162,7 +164,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListPayment" list-name="listIt" title="" type="list" >>> > >>> paginate-target="LookupPayment" >>> >>>> + >>>>>>>> + >>>>>>>> >>>>>>> <form name="ListPayment" list-name="listIt" title="" >>> > >>> paginate-target=" >>> >>>> LookupPayment" >>>>>>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -181,7 +184,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="amount"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="currencyUomId"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> + >>>>>>>> >>>>>>>> >>>>>>> <form name="LookupInvoice" target="LookupInvoice" title="" >>> > >>> type="single" >>> >>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> @@ -206,7 +209,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListInvoice" list-name="listIt" title="" type="list" >>> > >>> paginate-target="LookupInvoice" >>> >>>> + >>>>>>>> + >>>>>>>> >>>>>>> <form name="ListInvoice" list-name="listIt" title="" >>> > >>> paginate-target=" >>> >>>> LookupInvoice" >>>>>>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -238,7 +242,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListAgreements" list-name="listIt" title="" >>> > type="list" >>> >>>> target="LookupAgreement" >>>>>>>> + >>>>>>>> + >>>>>>>> >>>>>>> <grid name="ListAgreements" list-name="listIt" title="" >>> > type="list" >>> >>>> target="LookupAgreement" >>>>>>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -255,7 +260,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="agreementDate" title="${uiLabelMap. >>> > >>> CommonFromDate}"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="agreementTypeId"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="description"> >>> <display/> >>> </field> >>> >>>> - >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>> </grid> >>> >>>> >>>>>>>> >>>>>>> <form name="LookupAgreementItem" target="LookupAgreementItem" >>> > >>> title="" type="single" >>> >>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> @@ -269,7 +274,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListAgreementItems" list-name="listIt" title="" >>> > >>> type="list" target="LookupAgreementItem" >>> >>>> + >>>>>>>> + >>>>>>>> >>>>>>> <grid name="ListAgreementItems" list-name="listIt" title="" >>> > >>> target="LookupAgreementItem" >>> >>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -285,7 +291,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="agreementItemTypeId"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="currencyUomId"> >>> <display/> >>> </field> >>> >>>> - >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>> </grid> >>> >>>> >>>>>>>> >>>>>>> <form name="LookupPaymentGroupMember" >>> > >>> target="LookupPaymentGroupMember" >>> >>>> title="" type="single" header-row-style="header-row" >>>>>>>> default-table-style="basic-table"> >>>>>>>> >>>>>>>> >>>>>>> <field name="paymentGroupId"> >>> <text-find/> >>> </field> >>> >>>> @@ -296,7 +302,8 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListPaymentGroupMember" list-name="listIt" title="" >>> > >>> type="list" target="LookupPaymentGroupMember" >>> >>>> + >>>>>>>> + >>>>>>>> >>>>>>> <grid name="ListPaymentGroupMember" list-name="listIt" title="" >>> > >>> target="LookupPaymentGroupMember" >>> >>>> odd-row-style="alternate-row" default-table-style="basic- >>>>>>>> >>>>>>> table >>>>> >>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -323,7 +330,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="submitButton" title="${uiLabelMap. >>> CommonFind}" >>> >>>> widget-style="smallSubmit"> >>>>>>>> >>>>>>> <submit button-type="button"/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> </form> >>> >>>> - >>>>>>>> >>>>>>> <form name="ListLookupReconciliation" list-name="listIt" >>> > >>> type="list" >>> >>>> target="LookupGlReconciliation" >>>>>>>> + >>>>>>>> >>>>>>> <grid name="ListLookupReconciliation" list-name="listIt" >>> target=" >>> >>>> LookupGlReconciliation" >>>>>>>> odd-row-style="alternate-row" >>>>>>>> default-table-style="basic-table >>>>>>>> hover-bar"> >>>>>>>> >>>>>>>> >>>>>>> <actions> >>> >>>> >>>>>>>> >>>>>>> <service service-name="performFind" result-map="result" >>> > >>> result-map-list="listIt"> >>> >>>> @@ -339,7 +346,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="glReconciliationName"> >>> <display/> >>> </field> >>> >>>> >>>>>>>> >>>>>>> <field name="organizationPartyId"> >>> <display-entity >>> > >>> entity-name="PartyNameView" key-field-name="partyId" >>> >>>> description="${groupName}${firstName} ${lastName}[${partyId}]"/> >>>>>>>> >>>>>>> </ >>> > field> >>> >>>> >>>>>>>> >>>>>>> <field name="description" title="${uiLabelMap. >>> > >>> CommonDescription}"> >>> <display/> >>> </field> >>> >>>> - >>>>>>>> >>>>>>> </form> >>> >>>> + >>>>>>>> >>>>>>> </grid> >>> >>>> >>>>>>>> >>>>>>> <form name="LookupCustomTimePeriod" >>> > target="LookupCustomTimePeriod >>> >>>> " >>>>>>>> title="" type="single" >>>>>>>> header-row-style="header-row" >>>>>>>> >>>>>>> default-table-style="basic-tab >>>> >>>>> le"> >>>>>>>> @@ -366,7 +373,7 @@ under the License. >>>>>>>> >>>>>>>> >>>>>>> <field name="noConditionFind"> >>> <hidden value="Y"/> >>> </field> >>> >>>> >>>>>>> >>>>>>>
