Hi Jacques, Can you refer to the discussion thread and / or JIRA issue in which Marvin and Shane mentioned this info (if it is public) so we can learn and understand the legal basis of this decision?
Regards, On Sun, Apr 16, 2017 at 10:57 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Marvin and Shane think that this file should not be delivered with OFBiz > releases. I agree and will remove it. > > I see then no ways to save the usage of the ChartReport.ftl and Report.ftl > which rely on birt.tld. Hence the *HTML* demo reports associated need to be > removed (PDF demos are OK). > So we need to also remove things from the controller, BirtScreens.xml and > BirtMenus.xml. I believe we also need to prune web.xml. > > It seems to me that we need to remove the attachments folder And the > server-config.wsdd. I see no usage left of them > > These were all committed with http://svn.apache.org/viewvc?v > iew=revision&revision=892658 and later wrongly licensed in a bulk commit. > > I will create a Jira for that an attach a patch > > Jacques > > > > Le 14/04/2017 à 10:27, Jacques Le Roux a écrit : > >> I reopened LEGAL-296 >> >> Jacques >> >> >> Le 13/04/2017 à 22:42, Jacques Le Roux a écrit : >> >>> Yes it's indeed possible that we keep it. It's only 1 file, a bit more >>> editable than a DTD and not really a standard, but kind of in the Birt >>> ecosystem. >>> >>> I tend to agree with Marvin https://issues.apache.org/jira >>> /browse/LEGAL-296?focusedCommentId=15952957&page=com. >>> atlassian.jira.plugin.system.issuetabpanels:comment- >>> tabpanel#comment-15952957 >>> >>> that the exceptions should exist by projects and on request. We can ask >>> legal for this one since it's really on the edge unlike the case we sorted >>> with LEGAL-296 >>> >>> And yes we removed the webapp but the ChartReport.ftl and Report.ftl >>> continue to work well as long as the birt.tld file is there. >>> >>> I'll create a new LEGAL Jira! >>> >>> Thanks >>> >>> Jacques >>> >>> >>> Le 13/04/2017 à 19:44, Taher Alkhateeb a écrit : >>> >>>> I'm not an quite sure (I'm always bad with legalese) , but would this >>>> not >>>> qualify as category B [1] kind of source? It's a tag library needed at >>>> runtime as mentioned in the "Viewer Tag Library" header in [2]. Are we >>>> using the viewer for that matter or did we remove it completely? >>>> >>>> [1] http://www.apache.org/legal/resolved.html#category-b >>>> [2] http://www.eclipse.org/birt/documentation/integrating/viewer >>>> -usage.php >>>> >>>> On Thu, Apr 13, 2017 at 7:35 PM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> Hi, >>>>> >>>>> While working on HELP_BIRT.xml, I have found another issue regarding >>>>> the >>>>> birt component and the Birt license (EPL v1) >>>>> >>>>> It's said at >>>>> >>>>> https://www.eclipse.org/legal/epl/notice.php >>>>> >>>>> that all source maintained in the Birt repository is licensed under >>>>> EPL v1 >>>>> >>>>> The birt.tld file we use to render the example reports >>>>> >>>>> https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/b >>>>> irt/webapp/birt/WEB-INF/birt.tld >>>>> >>>>> is not a simple file and was wrongly licensed with a ASL2 header. >>>>> >>>>> The ChartReport.ftl and Report.ftl needs the birt.tld file and >>>>> unfortunately reading >>>>> >>>>> http://freemarker.org/docs/pgui_misc_servlet.html >>>>> >>>>> it seems we can't refer to an URL, like >>>>> >>>>> https://github.com/EclispeBIRT/org.eclipse.birt/blob/master/ >>>>> viewer/org.eclipse.birt.report.viewer/birt/WEB-INF/tlds/birt.tld >>>>> >>>>> So I'm afraid we need to remove the 2 reports FTL examples and the >>>>> birt.tld. >>>>> >>>>> We can still use the example.rptdesign and chart.rptdesign in other >>>>> ways. >>>>> Like we do for other reports or as examples for the Flexible Reports >>>>> but >>>>> I'm not sure it's worth the effort. >>>>> >>>>> What do you think? >>>>> >>>>> Jacques >>>>> >>>>> >>>>> >>> >>> >> >> >
