[
https://issues.apache.org/jira/browse/OMID-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412668#comment-15412668
]
ASF GitHub Bot commented on OMID-50:
------------------------------------
Github user francisco-perez-sorrosal commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/3#discussion_r73977397
--- Diff:
tso-server/src/main/java/org/apache/omid/tso/ReplyProcessorImpl.java ---
@@ -67,7 +69,7 @@
private final Meter timestampMeter;
@Inject
- ReplyProcessorImpl(MetricsRegistry metrics, Panicker panicker,
ObjectPool<Batch> batchPool) {
+ ReplyProcessorImpl(TSOServerConfig config, MetricsRegistry metrics,
Panicker panicker, ObjectPool<Batch> batchPool) {
--- End diff --
Same comment as above. Inject strategy instead of tso config. Should be:
```java
@Inject
ReplyProcessorImpl(@Named("ReplyStrategy") WaitStrategy strategy,
MetricsRegistry metrics,
Panicker panicker,
ObjectPool<Batch> batchPool) {
//
------------------------------------------------------------------------------------------------------------
// Disruptor initialization
//
------------------------------------------------------------------------------------------------------------
ThreadFactoryBuilder threadFactory = new
ThreadFactoryBuilder().setNameFormat("reply-%d");
this.disruptorExec =
Executors.newSingleThreadExecutor(threadFactory.build());
this.disruptor = new Disruptor<>(EVENT_FACTORY, 1 << 12,
disruptorExec, MULTI, strategy);
...
```
> Provide an option to reduce tso-server CPU usage
> ------------------------------------------------
>
> Key: OMID-50
> URL: https://issues.apache.org/jira/browse/OMID-50
> Project: Apache Omid
> Issue Type: Improvement
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.2.10
>
> Attachments: OMID-50-1.patch
>
>
> Currently tso-server use 300% cpu even at idle time. The reason for this 300%
> cpu usage is due to the BusyWaitStrategy used in disruptor. While this is
> good for throughput, it wastes resources in many use cases. In this ticket, I
> provide a config to use a different wait strategy and reduce the cpu usage
> with the option on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
