[ 
https://issues.apache.org/jira/browse/OMID-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414742#comment-15414742
 ] 

Francisco Perez-Sorrosal commented on OMID-50:
----------------------------------------------

Hi Daniel,

I´ve added two typos in the @Named injections in Reply and Retry processors. 
Apart from that, looks good to me. Remember also to put the \[OMID-50\] in the 
header of the commit and "This closes #3" in the body of the message.

Regarding amending and pushing with force, as long as the commit is not too 
big, it´s OK to me. The other approach is to push deltas and once the patch is 
approved, we can squash it in a single commit and push to master. That way we 
will be able to keep the comments in the github site.

> Provide an option to reduce tso-server CPU usage
> ------------------------------------------------
>
>                 Key: OMID-50
>                 URL: https://issues.apache.org/jira/browse/OMID-50
>             Project: Apache Omid
>          Issue Type: Improvement
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.2.10
>
>         Attachments: OMID-50-1.patch
>
>
> Currently tso-server use 300% cpu even at idle time. The reason for this 300% 
> cpu usage is due to the BusyWaitStrategy used in disruptor. While this is 
> good for throughput, it wastes resources in many use cases. In this ticket, I 
> provide a config to use a different wait strategy and reduce the cpu usage 
> with the option on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to