----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4444/#review6280 -----------------------------------------------------------
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java <https://reviews.apache.org/r/4444/#comment13623> Nope, it's backwards compatible... This exception is only thrown if you specify a naming convention ID which does not exist... If you don't specify the ID... which is what the peeps don't specify... Then the code will never reach this IF statement... The IF statement it is contained in will be false - brian On 2012-03-22 06:09:52, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4444/ > ----------------------------------------------------------- > > (Updated 2012-03-22 06:09:52) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > - Introduced NamingConvention support, which for MetExtractorProductCrawler > now takes an ID for the NamingConvention to use and AutoDetectProductCrawler > has a new element <namingConvention class=""/> in MimeExtractorRepo > - Also cleaned up handleFile(File)... documented better and is now public and > returns the IngestResult for what happened when called. > > > This addresses bug OODT-426. > https://issues.apache.org/jira/browse/OODT-426 > > > Diffs > ----- > > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java > 1302790 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java > 1302790 > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java > 1302790 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java > 1302790 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java > 1302790 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java > 1302790 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java > 1302790 > trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 > trunk/crawler/src/main/resources/crawler-config.xml 1302790 > trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 > trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/4444/diff > > > Testing > ------- > > Still need to unit-test up cas-crawler > > > Thanks, > > brian > >
