Hi Ross, Patches look good to me, no worries about committing directly. You are now a full PMC member and OODT committer, so use the force :)
Review Board is great because me, Ricky, Thomas B., Paul R., Sheryl, BFost, and others are actively leveraging it and love it. If you put your patches there you are bound to get tons of feedback (more so than JIRA atm). But I think you are fine with OODT-449, 452 and 453, we've discussed them plenty and there are no objections so +1 to move forward go for it! Cheers, Chris On May 23, 2012, at 7:11 PM, Ross Laidlaw wrote: > Hi Chris, > > I've uploaded patches for each sub-task for OODT-402 (these are > OODT-449, 452 and 453). I noted your comments and I wanted to ask > about the next steps. Would you like me to post the patches to review > board for a formal review? Or are you satisfied that everything's > looking good and covered in JIRA? If everything's fine and you're ok > for me to commit the changes I'd be happy to go ahead. > > Ross > > > On 15 May 2012 19:46, Mattmann, Chris A (388J) > <chris.a.mattm...@jpl.nasa.gov> wrote: >> +1 for RB! >> >> #win! >> >> Cheers, >> Chris >> >> On May 15, 2012, at 3:34 AM, Ramirez, Paul M (388J) wrote: >> >>> Hey Ricky, >>> >>> Sounds good. You can always just implement it as a patch and then when its >>> done commit it to the repo. That would make it easy to push through review >>> board too. >>> >>> --Paul >>> >>> On 5/14/12 9:16 PM, "Mattmann, Chris A (388J)" >>> <chris.a.mattm...@jpl.nasa.gov> wrote: >>> >>>> Hey Ricky, >>>> >>>> That's awesome, glad that you started those and hope you can >>>> dig them up! >>>> >>>> Cheers, >>>> Chris >>>> >>>> On May 14, 2012, at 5:03 PM, Ross Laidlaw wrote: >>>> >>>>> Hi Ricky, >>>>> >>>>> On 14 May 2012 21:26, Nguyen, Ricky <rngu...@chla.usc.edu> wrote: >>>>>> FYI, I've got some code lying around that ports the DataDeliverServlet >>>>>> and DatasetDeliveryServlet to JAX-RS using CXF. The reason I started it >>>>>> was because I thought we might be able to make use of CXF's oauth >>>>>> providers to secure this RESTful web service. But I hadn't figured out >>>>>> the oauth part (nor how to port the RDF/RSS servlets). >>>>>> >>>>>> If I find time, maybe I'll start a branch... >>>>>> >>>>>> -Ricky >>>>> >>>>> Sounds good. I'll try to close out OODT-402 and OODT-458 first, but >>>>> after that I'd be happy to contribute to this work if there's anything >>>>> I can do to help out. By the way, I found your emails with Chris and >>>>> Andrew about the various ways of serving files from File Manager very >>>>> informative! Really helped me to learn about all of the different >>>>> services available. >>>>> >>>>> Ross >>>> >>>> >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> Chris Mattmann, Ph.D. >>>> Senior Computer Scientist >>>> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA >>>> Office: 171-266B, Mailstop: 171-246 >>>> Email: chris.a.mattm...@nasa.gov >>>> WWW: http://sunset.usc.edu/~mattmann/ >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> Adjunct Assistant Professor, Computer Science Department >>>> University of Southern California, Los Angeles, CA 90089 USA >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> >>> >> >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Chris Mattmann, Ph.D. >> Senior Computer Scientist >> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA >> Office: 171-266B, Mailstop: 171-246 >> Email: chris.a.mattm...@nasa.gov >> WWW: http://sunset.usc.edu/~mattmann/ >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Adjunct Assistant Professor, Computer Science Department >> University of Southern California, Los Angeles, CA 90089 USA >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
