[ 
https://issues.apache.org/jira/browse/OOZIE-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510226#comment-13510226
 ] 

Mohammad Kamrul Islam commented on OOZIE-1111:
----------------------------------------------

Comment copied and pasted from review:

Mohammad Islam:

Why are you changing back to adding "database", "table" etc? I think we talked 
to add "partition".
Although it was our original plan. We changed it after getting feedback from 
Alejandro. As stated "database & table, why not assuming the database and table 
names are the first and second elements of the path, then instead 
hcat:host:port/db/<DB>/table/<TABLE>/... it would just be 
#hcat:host:port/<DB>/<TABLE>/...".

    Ryota Egashira 6 hours, 7 minutes from now (Dec. 5, 2012, 12:39 a.m.)

        yeah, we removed it in original design, but to follow templeton URI 
format which require these, we are adding
        
https://issues.apache.org/jira/browse/OOZIE-561?focusedCommentId=13509053&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13509053

    Rohini Palaniswamy 6 hours, 12 minutes from now (Dec. 5, 2012, 12:44 a.m.)

        That's the templeton format 
(http://people.apache.org/~thejas/templeton_doc_latest/descpartition.html). If 
we are trying to comply with it, we should totally comply with it 
(https://issues.apache.org/jira/browse/OOZIE-561?focusedCommentId=13509053&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13509053).
 Adding partition without database and table does not make sense. Else we can 
go with hcat:host:port/<DB>/<TABLE>/<PARTITION> assuming that the third one 
will be partition. Both has its pros and cons. One would be more standard 
complying with hcatalog folks. The other is simplified (less to type for user) 
and takes less space for string while storing in database.  Had not thought 
about templeton uri taking more space in oozie database before. 

          We need an agreement on the final format of the uri. I am fine with 
either one of the two approaches except the former one where partition was part 
of query params. 

    Ryota Egashira 7 hours, 3 minutes from now (Dec. 5, 2012, 1:35 a.m.)

        one alternative coming from discussion is to use URI encoder/decoder 
        we could have 2 formats, one exposed to user as uti-template, one for 
oozie internal format, and use encoder/decoder class to convert one to the 
other. advantage is that we can isolate these two, also we can make internal 
format to tiny not to eat up size in DB.



    Mohammad Islam 7 hours, 59 minutes from now (Dec. 5, 2012, 2:31 a.m.)

        I'm also not 100% convinced in one way or the other. But we have to 
consider few things:
        1. User should not type extra things.
        2. The design should be extendable.
        3. For oozie internal, we should store as little as possible.

        The problem is: HCatalog didn't define anything. If they do, our life 
would be much easier. HCatalog doesn't want to support any URI like format.  As 
far as I know, Templeton is a separate/independent project.

        Since it is an interface issue (which we shouldn't modify often), I 
would ask Alejandro's comment. I will ping him and upload this discussion to 
the JIRA as well.





                
> change HCatURI to comply with templeton URI format
> --------------------------------------------------
>
>                 Key: OOZIE-1111
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1111
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Ryota Egashira
>            Assignee: Ryota Egashira
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to