----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8679/#review14733 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/8679/#comment31281> If there is an exception here, you should log and continue. Not throw error materializing. branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8679/#comment31280> Don't replace a hardcoded scheme. Replace the scheme till :// branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8679/#comment31282> Does this ever return true? You are doing a uri.toString in HCatURIHandler and the map only has the authority. You should pass the URI and check for uri.getAuthority() in connSessionMap branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8679/#comment31284> Same here. You should be checking for scheme://authority instead of the full uri. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8679/#comment31285> Can initialize the default rule as a class variable while initializing the rules instead of doing it everytime. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8679/#comment31286> close the exception in a finally block and close quietly. i.e ignore exceptions while closing connections. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8679/#comment31288> If there are more partitions available in between you will be returning false and logging a spurious warning in CoordActionUpdatePushMissingDependency that you were not able to remove even though it was removed. Better not return false in this case and return only if actionId could not be found. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8679/#comment31287> throw new MetadataServiceException(ErrorCode.E1025, hcatURI, e); - Rohini Palaniswamy On Dec. 20, 2012, 2:53 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8679/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2012, 2:53 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1138 > > > This addresses bug OOZIE-1138. > https://issues.apache.org/jira/browse/OOZIE-1138 > > > Diffs > ----- > > branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java > PRE-CREATION > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > 1424271 > branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1424271 > > Diff: https://reviews.apache.org/r/8679/diff/ > > > Testing > ------- > > end to end test done and connections to jms server verified > > > Thanks, > > Virag Kothari > >
