> On Dec. 20, 2012, 11:43 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java, > > line 63 > > <https://reviews.apache.org/r/8679/diff/2/?file=241546#file241546line63> > > > > typo for "queuing". Also make READY in caps
k > On Dec. 20, 2012, 11:43 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java, > > line 39 > > <https://reviews.apache.org/r/8679/diff/2/?file=241555#file241555line39> > > > > Javadoc to understand this better good suggestion..otherwise the bot would complain gng forward > On Dec. 20, 2012, 11:43 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java, > > line 40 > > <https://reviews.apache.org/r/8679/diff/2/?file=241555#file241555line40> > > > > this will always be true.You could another constructor that accepts > > boolean argument for patternMatch No..its only true when the rule has '$' > On Dec. 20, 2012, 11:43 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java, > > line 56 > > <https://reviews.apache.org/r/8679/diff/2/?file=241562#file241562line56> > > > > what does this statement mean? both servers should connect to default JMS server.. will make the last word singular > On Dec. 20, 2012, 11:43 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java, > > line 244 > > <https://reviews.apache.org/r/8679/diff/2/?file=241563#file241563line244> > > > > should be getAvailableMap().get(actionId1).size() correct..thxs - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8679/#review14786 ----------------------------------------------------------- On Dec. 20, 2012, 2:53 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8679/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2012, 2:53 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1138 > > > This addresses bug OOZIE-1138. > https://issues.apache.org/jira/browse/OOZIE-1138 > > > Diffs > ----- > > branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1424271 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java > PRE-CREATION > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > 1424271 > branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1424271 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1424271 > > Diff: https://reviews.apache.org/r/8679/diff/ > > > Testing > ------- > > end to end test done and connections to jms server verified > > > Thanks, > > Virag Kothari > >
