> On Dec. 20, 2012, 8:07 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java, > > line 249 > > <https://reviews.apache.org/r/8673/diff/4/?file=241485#file241485line249> > > > > shouldn't the partition quotes be appended by the pig script > > (application)
The HCatStorer code was not taking the entire string e.g. 'partitionkey=value' unless it is enclosed in quotes, and was ending up delimiting at =. So this was added after end-to-end testing > On Dec. 20, 2012, 8:07 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, > > line 299 > > <https://reviews.apache.org/r/8673/diff/4/?file=241484#file241484line299> > > > > I dont think arrray length can ever be 0. Can you check it? you are right. removing that block > On Dec. 20, 2012, 8:07 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, > > line 204 > > <https://reviews.apache.org/r/8673/diff/4/?file=241484#file241484line204> > > > > instead of doing substring and split to get rid of the first element of > > uriList, its better to have a for loop which doesn't read the first element. > > Same for max partition el function done > On Dec. 20, 2012, 8:07 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, > > line 202 > > <https://reviews.apache.org/r/8673/diff/4/?file=241484#file241484line202> > > > > Can we have error handling when minPartition is null?..same comment for > > maxPartition el function if it is found to be null, all further comparisons are also invalid and this qualifies for an exception. adding it. > On Dec. 20, 2012, 8:07 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, > > line 177 > > <https://reviews.apache.org/r/8673/diff/4/?file=241484#file241484line177> > > > > As dataOut uri is a single uri and not an array of URI, why not call > > the tofilter() of HcatURI directly. > > The createPartitionFilter does string operations which doesn't seem > > required for dataOut. done. thanks - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8673/#review14769 ----------------------------------------------------------- On Dec. 20, 2012, 7 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8673/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2012, 7 p.m.) > > > Review request for oozie. > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1123 > All HCatalog related EL functions separated out into another class. Changed > nomenclature instead of having 'meta' > WIP - URIHandler to determine EL Functions to FS and HCat URIs and throw > error otherwise > > > This addresses bug OOZIE-1123. > https://issues.apache.org/jira/browse/OOZIE-1123 > > > Diffs > ----- > > branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java > PRE-CREATION > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > 1424233 > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java > 1424233 > branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java > PRE-CREATION > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java > 1424233 > branches/hcat-intre/examples/src/main/apps/hcatalog/README PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/coordinator.xml > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/id.pig PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/job.properties > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/workflow.xml > PRE-CREATION > branches/hcat-intre/pom.xml 1424233 > branches/hcat-intre/sharelib/hive/pom.xml 1424233 > > Diff: https://reviews.apache.org/r/8673/diff/ > > > Testing > ------- > > unit tests added. end-to-end test will be done using Pig job > > > Thanks, > > Mona Chitnis > >
