----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8673/#review14799 -----------------------------------------------------------
branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/8673/#comment31418> If this is the first error, even if there are other errors you will tell that the schema is valid. Need to give the escaped xml to the validator branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/8673/#comment31421> Same as before. Pass the escaped xml for validation. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31441> dataOutPartitions ? Plural would make it clearer to user. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31430> Can we rename this to dataInPartitionPigFilter? Just realized we will need to add one for Hive later. One has == and other = branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31424> error or warn branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31432> Shouldn't this be a comma separated list? Use a different method in HCatURI for it as it is not a filter. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31435> We need something that does string compare if string and num compare if number (natural sorting). Else 11 will come before 2. Cases that could happen are if they are just doing date as the column without the timestamp or a monotonically increasing sequence number as the column. We could first try sorting by number. If there is an exception we could switch to sorting by string. That seems to be the simplest thing we can do. natural sorting seems to be tricky. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31437> same comments as min branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31439> Either use enum for type (no string compare) or have two separate methods . branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/8673/#comment31428> Use two different methods specifying the intent (toPigPartitionFilter() and toPartitionStringHCatStorer()). This is hacky. - Rohini Palaniswamy On Dec. 21, 2012, 12:04 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8673/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2012, 12:04 a.m.) > > > Review request for oozie. > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1123 > All HCatalog related EL functions separated out into another class. Changed > nomenclature instead of having 'meta' > WIP - URIHandler to determine EL Functions to FS and HCat URIs and throw > error otherwise > > > This addresses bug OOZIE-1123. > https://issues.apache.org/jira/browse/OOZIE-1123 > > > Diffs > ----- > > branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java > PRE-CREATION > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1424233 > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java > 1424233 > branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java > PRE-CREATION > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java > 1424233 > branches/hcat-intre/examples/src/main/apps/hcatalog/README PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/coordinator.xml > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/id.pig PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/job.properties > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/workflow.xml > PRE-CREATION > branches/hcat-intre/pom.xml 1424233 > branches/hcat-intre/sharelib/hive/pom.xml 1424233 > > Diff: https://reviews.apache.org/r/8673/diff/ > > > Testing > ------- > > unit tests added. end-to-end test will be done using Pig job > > > Thanks, > > Mona Chitnis > >
