----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9282/#review17422 -----------------------------------------------------------
Ship it! Ship It! - Mona Chitnis On Feb. 4, 2013, 6:47 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9282/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 6:47 a.m.) > > > Review request for oozie. > > > Description > ------- > > <sla:should-end>${ ${SLA_OFFSET} * MINUTES}</sla:should-end> > > is not working since the entire text value is passed to commons.el evaluator. > > <sla:should-end>${ SLA_OFFSET * MINUTES}</sla:should-end> > > works. > > I also have a review request to illustrate what I mean with a tweaked test. > I believe the user case is invalid and no code change is required. > Let me know if it makes sense. > > > This addresses bug OOZIE-1204. > https://issues.apache.org/jira/browse/OOZIE-1204 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1441877 > > Diff: https://reviews.apache.org/r/9282/diff/ > > > Testing > ------- > > > Thanks, > > jun aoki > >
