> On March 5, 2013, 8:11 p.m., Mona Chitnis wrote: > > Ship It!
Hi Mona, thank you for taking a look. The issue (https://issues.apache.org/jira/browse/OOZIE-1204) is complaining a syntax like below does not work. <sla:should-end>${ ${SLA_OFFSET} * MINUTES}</sla:should-end> This does not work indeed, since it is not how commons.el package works. Instead, a syntax below works as is in this patch review. <sla:should-end>${ SLA_OFFSET * MINUTES}</sla:should-end> The patch is to modify a test to illustrate (but again Nothing to be fixed) Question to your "Ship It!"; did you mean to still apply the patch and show as example? and close the issue as the use case is invalid? - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9282/#review17422 ----------------------------------------------------------- On Feb. 4, 2013, 6:47 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9282/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 6:47 a.m.) > > > Review request for oozie. > > > Description > ------- > > <sla:should-end>${ ${SLA_OFFSET} * MINUTES}</sla:should-end> > > is not working since the entire text value is passed to commons.el evaluator. > > <sla:should-end>${ SLA_OFFSET * MINUTES}</sla:should-end> > > works. > > I also have a review request to illustrate what I mean with a tweaked test. > I believe the user case is invalid and no code change is required. > Let me know if it makes sense. > > > This addresses bug OOZIE-1204. > https://issues.apache.org/jira/browse/OOZIE-1204 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1441877 > > Diff: https://reviews.apache.org/r/9282/diff/ > > > Testing > ------- > > > Thanks, > > jun aoki > >
