----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16756/#review32667 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java <https://reviews.apache.org/r/16756/#comment61579> Can you add a unit test for this? (I know it seems silly because this method simply returns false, but it will help ensure that we don't accidentally change it later). You can just copy the test for ZKJobsConcurrencyService#isAllServerRequest (see next comment) and make it always assertFalse core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java <https://reviews.apache.org/r/16756/#comment61581> Can you add a unit test for this? Just call it with some different params and verify that it works correctly. core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/16756/#comment61578> typo: "shatelib" should be "sharelib" - Robert Kanter On Jan. 22, 2014, 7:27 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16756/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7:27 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1609 > https://issues.apache.org/jira/browse/OOZIE-1609 > > > Repository: oozie-git > > > Description > ------- > > Sharelib support for HA. > > 1.Sharelib update : Server calls other server to update sharelib. > 2.Purging of sharelib : only first server deletes sharelib. > > > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 9d6c9e0 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > f65239d > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 99c16e0 > core/src/main/java/org/apache/oozie/service/ShareLibService.java 9556620 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 42fce05 > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > c17a8aa > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 091070f > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java e69de29 > core/src/test/java/org/apache/oozie/service/DummyV2AdminServlet.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > e69de29 > docs/src/site/twiki/DG_CommandLineTool.twiki af472d3 > docs/src/site/twiki/WebServicesAPI.twiki 50795b4 > > Diff: https://reviews.apache.org/r/16756/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
