----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16756/#review32765 -----------------------------------------------------------
+1 pending my last minor comment on TestJobsConcurrencyService core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java <https://reviews.apache.org/r/16756/#comment61740> Good catch :) core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java <https://reviews.apache.org/r/16756/#comment61741> Can you also put the same checks from the similar test from TestZKJobsConcurrencyService here, but with assertFalse? i.e. assertFalse(zkjcs.isAllServerRequest(null)); Map<String, String[]> param = new HashMap<String, String[]>(); assertFalse(zkjcs.isAllServerRequest(param)); param.put(RestConstants.ALL_SERVER_REQUEST, new String[] { "test" }); assertFalse(zkjcs.isAllServerRequest(param)); param.put(RestConstants.ALL_SERVER_REQUEST, new String[] { "true" }); assertFalse(zkjcs.isAllServerRequest(param)); param.put(RestConstants.ALL_SERVER_REQUEST, new String[] { "false" }); assertFalse(zkjcs.isAllServerRequest(param)); This will ensure that regardless of the parameter, when not using Oozie HA, the method always returns false - Robert Kanter On Jan. 24, 2014, 12:32 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16756/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 12:32 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1609 > https://issues.apache.org/jira/browse/OOZIE-1609 > > > Repository: oozie-git > > > Description > ------- > > Sharelib support for HA. > > 1.Sharelib update : Server calls other server to update sharelib. > 2.Purging of sharelib : only first server deletes sharelib. > > > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 9d6c9e0 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > f65239d > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 99c16e0 > core/src/main/java/org/apache/oozie/service/ShareLibService.java 9556620 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 42fce05 > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > c17a8aa > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 091070f > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java e69de29 > core/src/test/java/org/apache/oozie/service/DummyV2AdminServlet.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > 4a0067f > > core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java > 330b620 > core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > c869b12 > docs/src/site/twiki/DG_CommandLineTool.twiki af472d3 > docs/src/site/twiki/WebServicesAPI.twiki 50795b4 > > Diff: https://reviews.apache.org/r/16756/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
