----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review43431 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77573> protected core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77581> Make it "else if" instead of nesting if inside else block core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java <https://reviews.apache.org/r/17720/#comment77568> throw new UnSupportedOperationException(). Add this method to QueryExecutor itself and remove empty overriding in each class. core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/17720/#comment77569> getEntityKey() will never be null core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/17720/#comment77571> Move this inside if (multipleServerRunning) block. core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/17720/#comment77572> private static core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77576> Use an iterator and do iter.remove() core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77578> Just removing from historySet is not enough. Need to update the start, end, duration based on the completion times. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77579> Put the try catch inside the loop, so that even if there is an error for one we iterate over others. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment77580> multipleServerRunning still not handled here core/src/test/java/org/apache/oozie/service/TestHASLAService.java <https://reviews.apache.org/r/17720/#comment77583> private core/src/test/java/org/apache/oozie/service/TestHASLAService.java <https://reviews.apache.org/r/17720/#comment77584> Should not be the case. A completed action should not be in history set. - Rohini Palaniswamy On May 16, 2014, 11:46 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17720/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 11:46 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1678 > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > ea7df17 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > d2331e8 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 319aea0 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 1a6ded7 > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e3b115f > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > 79d11ed > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 9156a27 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > e7d42e9 > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > 7b4e177 > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java > 1510daf > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java > 1f7cb4d > core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 27c97e6 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 611b74c > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > bc24235 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java > 00fb677 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java > 2e170a4 > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java > ea36720 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 9270aa2 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 9a16722 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 3ce86ab > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 40376a5 > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > cd2fbae > core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 > > core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 3a9e72e > core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 > core/src/test/resources/coord-action-sla.xml e88df6c > > Diff: https://reviews.apache.org/r/17720/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
